All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 2/5] x86/ELF: don't open-code read_sreg()
Date: Mon, 28 Sep 2020 14:05:58 +0200	[thread overview]
Message-ID: <e15d4ed7-4a42-33ac-79ed-171851548a1b@suse.com> (raw)
In-Reply-To: <ec4b451e-2b93-8526-ef98-7a2d502e31c2@suse.com>

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/asm-x86/x86_64/elf.h
+++ b/xen/include/asm-x86/x86_64/elf.h
@@ -1,6 +1,8 @@
 #ifndef __X86_64_ELF_H__
 #define __X86_64_ELF_H__
 
+#include <asm/regs.h>
+
 typedef struct {
     unsigned long r15;
     unsigned long r14;
@@ -53,16 +55,16 @@ static inline void elf_core_save_regs(EL
     asm volatile("movq %%rdi,%0" : "=m"(core_regs->rdi));
     /* orig_rax not filled in for now */
     core_regs->rip = (unsigned long)elf_core_save_regs;
-    asm volatile("movl %%cs, %%eax;" :"=a"(core_regs->cs));
+    core_regs->cs = read_sreg(cs);
     asm volatile("pushfq; popq %0" :"=m"(core_regs->rflags));
     asm volatile("movq %%rsp,%0" : "=m"(core_regs->rsp));
     asm volatile("movl %%ss, %%eax;" :"=a"(core_regs->ss));
     /* thread_fs not filled in for now */
     /* thread_gs not filled in for now */
-    asm volatile("movl %%ds, %%eax;" :"=a"(core_regs->ds));
-    asm volatile("movl %%es, %%eax;" :"=a"(core_regs->es));
-    asm volatile("movl %%fs, %%eax;" :"=a"(core_regs->fs));
-    asm volatile("movl %%gs, %%eax;" :"=a"(core_regs->gs));
+    core_regs->ds = read_sreg(ds);
+    core_regs->es = read_sreg(es);
+    core_regs->fs = read_sreg(fs);
+    core_regs->gs = read_sreg(gs);
 
     asm volatile("mov %%cr0, %0" : "=r" (tmp) : );
     xen_core_regs->cr0 = tmp;


  parent reply	other threads:[~2020-09-28 12:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 12:04 [PATCH 0/5] x86: introduce read_sregs() and elf_core_save_regs() adjustments Jan Beulich
2020-09-28 12:05 ` [PATCH 1/5] x86: introduce read_sregs() to allow storing to memory directly Jan Beulich
2020-09-28 12:47   ` Andrew Cooper
2020-09-28 13:29     ` Jan Beulich
2020-09-28 14:49     ` Jan Beulich
2020-09-28 15:11       ` Andrew Cooper
2020-09-28 12:05 ` Jan Beulich [this message]
2020-09-28 12:57   ` [PATCH 2/5] x86/ELF: don't open-code read_sreg() Andrew Cooper
2020-09-28 12:06 ` [PATCH 3/5] x86/ELF: don't store function pointer in elf_core_save_regs() Jan Beulich
2020-09-28 12:58   ` Andrew Cooper
2020-09-28 12:06 ` [PATCH 4/5] x86/ELF: also record FS/GS bases " Jan Beulich
2020-09-28 13:04   ` Andrew Cooper
2020-09-28 13:38     ` Jan Beulich
2020-09-28 12:07 ` [PATCH 5/5] x86/ELF: eliminate pointless local variable from elf_core_save_regs() Jan Beulich
2020-09-28 13:06   ` Andrew Cooper
2020-09-28 15:04 ` [PATCH 6/5] x86/ELF: drop unnecessary volatile from asm()-s in elf_core_save_regs() Jan Beulich
2020-09-28 15:15   ` Andrew Cooper
2020-09-28 15:40     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e15d4ed7-4a42-33ac-79ed-171851548a1b@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.