From: andrey.konovalov@linux.dev To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Peter Collingbourne <pcc@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, kasan-dev@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Subject: [PATCH 11/31] kasan, page_alloc: move SetPageSkipKASanPoison in post_alloc_hook Date: Tue, 30 Nov 2021 23:05:17 +0100 [thread overview] Message-ID: <e38327856eb2cc233e478e22e618d9f0454db62a.1638308023.git.andreyknvl@google.com> (raw) In-Reply-To: <cover.1638308023.git.andreyknvl@google.com> From: Andrey Konovalov <andreyknvl@google.com> Pull the SetPageSkipKASanPoison() call in post_alloc_hook() out of the big if clause for better code readability. This also allows for more simplifications in the following patches. Also turn the kasan_has_integrated_init() check into the proper CONFIG_KASAN_HW_TAGS one. These checks evaluate to the same value, but logically skipping kasan poisoning has nothing to do with integrated init. Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- mm/page_alloc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e3e9fefbce43..c78befc4e057 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2421,9 +2421,6 @@ inline void post_alloc_hook(struct page *page, unsigned int order, init = false; } if (kasan_has_integrated_init()) { - if (gfp_flags & __GFP_SKIP_KASAN_POISON) - SetPageSkipKASanPoison(page); - if (!init_tags) kasan_unpoison_pages(page, order, init); } else { @@ -2432,6 +2429,10 @@ inline void post_alloc_hook(struct page *page, unsigned int order, if (init) kernel_init_free_pages(page, 1 << order); } + /* Propagate __GFP_SKIP_KASAN_POISON to page flags. */ + if (IS_ENABLED(CONFIG_KASAN_HW_TAGS) && + (gfp_flags & __GFP_SKIP_KASAN_POISON)) + SetPageSkipKASanPoison(page); set_page_owner(page, order, gfp_flags); } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: andrey.konovalov@linux.dev To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Peter Collingbourne <pcc@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, kasan-dev@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Subject: [PATCH 11/31] kasan, page_alloc: move SetPageSkipKASanPoison in post_alloc_hook Date: Tue, 30 Nov 2021 23:05:17 +0100 [thread overview] Message-ID: <e38327856eb2cc233e478e22e618d9f0454db62a.1638308023.git.andreyknvl@google.com> (raw) In-Reply-To: <cover.1638308023.git.andreyknvl@google.com> From: Andrey Konovalov <andreyknvl@google.com> Pull the SetPageSkipKASanPoison() call in post_alloc_hook() out of the big if clause for better code readability. This also allows for more simplifications in the following patches. Also turn the kasan_has_integrated_init() check into the proper CONFIG_KASAN_HW_TAGS one. These checks evaluate to the same value, but logically skipping kasan poisoning has nothing to do with integrated init. Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- mm/page_alloc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e3e9fefbce43..c78befc4e057 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2421,9 +2421,6 @@ inline void post_alloc_hook(struct page *page, unsigned int order, init = false; } if (kasan_has_integrated_init()) { - if (gfp_flags & __GFP_SKIP_KASAN_POISON) - SetPageSkipKASanPoison(page); - if (!init_tags) kasan_unpoison_pages(page, order, init); } else { @@ -2432,6 +2429,10 @@ inline void post_alloc_hook(struct page *page, unsigned int order, if (init) kernel_init_free_pages(page, 1 << order); } + /* Propagate __GFP_SKIP_KASAN_POISON to page flags. */ + if (IS_ENABLED(CONFIG_KASAN_HW_TAGS) && + (gfp_flags & __GFP_SKIP_KASAN_POISON)) + SetPageSkipKASanPoison(page); set_page_owner(page, order, gfp_flags); } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 22:05 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 21:39 [PATCH 00/31] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:39 ` [PATCH 01/31] kasan, page_alloc: deduplicate should_skip_kasan_poison andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:39 ` [PATCH 02/31] kasan, page_alloc: move tag_clear_highpage out of kernel_init_free_pages andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-02 15:24 ` Alexander Potapenko 2021-12-02 15:24 ` Alexander Potapenko 2021-11-30 21:39 ` [PATCH 03/31] kasan, page_alloc: merge kasan_free_pages into free_pages_prepare andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-02 15:32 ` Alexander Potapenko 2021-12-02 15:32 ` Alexander Potapenko 2021-11-30 21:39 ` [PATCH 04/31] kasan, page_alloc: simplify kasan_poison_pages call site andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-01 14:09 ` Marco Elver 2021-12-01 14:09 ` Marco Elver 2021-12-06 21:07 ` Andrey Konovalov 2021-12-06 21:07 ` Andrey Konovalov 2021-11-30 21:39 ` [PATCH 05/31] kasan, page_alloc: init memory of skipped pages on free andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:41 ` [PATCH 06/31] mm: clarify __GFP_ZEROTAGS comment andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-11-30 21:41 ` [PATCH 07/31] kasan: only apply __GFP_ZEROTAGS when memory is zeroed andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-12-02 15:40 ` Alexander Potapenko 2021-12-02 15:40 ` Alexander Potapenko 2021-11-30 21:41 ` [PATCH 08/31] kasan, page_alloc: refactor init checks in post_alloc_hook andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-12-02 16:13 ` Alexander Potapenko 2021-12-02 16:13 ` Alexander Potapenko 2021-12-06 21:09 ` Andrey Konovalov 2021-12-06 21:09 ` Andrey Konovalov 2021-12-16 10:59 ` Alexander Potapenko 2021-12-16 10:59 ` Alexander Potapenko 2021-11-30 21:42 ` [PATCH 09/31] kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook andrey.konovalov 2021-11-30 21:42 ` andrey.konovalov 2021-11-30 21:52 ` [PATCH 10/31] kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook andrey.konovalov 2021-11-30 21:52 ` andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov [this message] 2021-11-30 22:05 ` [PATCH 11/31] kasan, page_alloc: move SetPageSkipKASanPoison " andrey.konovalov 2021-11-30 22:05 ` [PATCH 12/31] kasan, page_alloc: move kernel_init_free_pages " andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov 2021-11-30 22:05 ` [PATCH 13/31] kasan, page_alloc: simplify kasan_unpoison_pages call site andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 14/31] kasan: clean up metadata byte definitions andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 15/31] kasan: define KASAN_VMALLOC_INVALID for SW_TAGS andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 16/31] kasan, x86, arm64, s390: rename functions for modules shadow andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 17/31] kasan, vmalloc: drop outdated VM_KASAN comment andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 18/31] kasan: reorder vmalloc hooks andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 20/31] kasan, vmalloc: reset tags in vmalloc functions andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-02 14:17 ` Marco Elver 2021-12-02 14:17 ` Marco Elver 2021-12-06 21:08 ` Andrey Konovalov 2021-12-06 21:08 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 19/31] kasan: add wrappers for vmalloc hooks andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 21/31] kasan, fork: don't tag stacks allocated with vmalloc andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-02 14:27 ` Marco Elver 2021-12-02 14:27 ` Marco Elver 2021-12-06 21:08 ` Andrey Konovalov 2021-12-06 21:08 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 22/31] kasan, vmalloc: add vmalloc support to SW_TAGS andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 23/31] kasan, arm64: allow KASAN_VMALLOC with SW_TAGS andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-03 12:37 ` Marco Elver 2021-12-03 12:37 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 24/31] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-03 12:42 ` Marco Elver 2021-12-03 12:42 ` Marco Elver 2021-12-06 21:12 ` Andrey Konovalov 2021-12-06 21:12 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 25/31] kasan, vmalloc: don't unpoison VM_ALLOC pages before mapping andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 26/31] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 27/31] kasan, vmalloc: add vmalloc support to HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-03 12:41 ` Marco Elver 2021-12-03 12:41 ` Marco Elver 2021-12-06 21:12 ` Andrey Konovalov 2021-12-06 21:12 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 28/31] kasan: add kasan.vmalloc command line flag andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-03 12:09 ` Marco Elver 2021-12-03 12:09 ` Marco Elver 2021-12-06 21:09 ` Andrey Konovalov 2021-12-06 21:09 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 29/31] kasan, arm64: allow KASAN_VMALLOC with HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-01 11:35 ` Marco Elver 2021-12-01 11:35 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-12-03 12:40 ` Marco Elver 2021-12-03 12:40 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 30/31] kasan: documentation updates andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 31/31] kasan: improve vmalloc tests andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e38327856eb2cc233e478e22e618d9f0454db62a.1638308023.git.andreyknvl@google.com \ --to=andrey.konovalov@linux.dev \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@gmail.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=pcc@google.com \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.