All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: tep_free_plugin_paths() function in libtraceevent
Date: Fri, 11 Sep 2020 03:08:16 +0100	[thread overview]
Message-ID: <e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@decadent.org.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

I noticed that the new function tep_free_plugin_paths() is exported
from libtraceevent, but is only declared in a private header file.

If it's meant to be part of the API, it should be declared in a public
header file.  If not, I think it should be hidden from library users.

(I think there are other only functions with this issue; this just came
to my attention because the Debian packaging tools prompted me to
update the symbol-to-minimum-version mapping.)

Ben.

-- 
Ben Hutchings
Never put off till tomorrow what you can avoid all together.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2020-09-11  2:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  2:08 Ben Hutchings [this message]
2020-09-14 21:29 ` tep_free_plugin_paths() function in libtraceevent Arnaldo Carvalho de Melo
2020-09-15 13:12   ` Tzvetomir Stoyanov
2020-09-15 13:26     ` Ben Hutchings
2020-09-15 13:41       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=acme@kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.