From: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, Linux OMAP Mailing List <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>, Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>, Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>, Device Tree Mailing List <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux ARM Mailing List <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> Subject: Re: [PATCH v2 4/9] regulator: lp873x: Add support for populating input supply Date: Wed, 2 Nov 2016 10:58:40 +0530 [thread overview] Message-ID: <e5619d78-5752-c8fb-8a11-6629c4b7c3f6@ti.com> (raw) In-Reply-To: <20161030204118.ojeetnxl5qsi6lp7@rob-hp-laptop> On Monday 31 October 2016 02:11 AM, Rob Herring wrote: > On Fri, Oct 21, 2016 at 04:08:36PM +0530, Lokesh Vutla wrote: >> In order to have a proper topology of regulators for a platform, each >> registering regulator needs to populate supply_name field for identifying >> its supply's name. Add supply_name field for lp873x regulators. >> >> Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Cc: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> >> Signed-off-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> >> --- >> Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ >> drivers/regulator/lp873x-regulator.c | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt >> index 52766c2..998837a 100644 >> --- a/Documentation/devicetree/bindings/mfd/lp873x.txt >> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt >> @@ -7,6 +7,9 @@ Required properties: >> - #gpio-cells: Should be two. The first cell is the pin number and >> the second cell is used to specify flags. >> See ../gpio/gpio.txt for more information. >> + - xxx-in-supply: Phandle to parent supply node of each regulator >> + populated under regulators node. xxx should match >> + the supply_name populated in driver. > > The driver is irrelevant. This should reference a list in this document. okay. See if the below updated patch is fine. -----------------------------8<----------------------------8<---------------------------- >From 666f925423fa35c7bfcc77fa3c883cbea5d8ef8e Mon Sep 17 00:00:00 2001 From: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> Date: Wed, 21 Sep 2016 11:50:49 +0530 Subject: [PATCH v3] regulator: lp873x: Add support for populating input supply In order to have a proper topology of regulators for a platform, each registering regulator needs to populate supply_name field for identifying its supply's name. Add supply_name field for lp873x regulators. Signed-off-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> --- Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ drivers/regulator/lp873x-regulator.c | 1 + 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt index 52766c2..ae9cf39 100644 --- a/Documentation/devicetree/bindings/mfd/lp873x.txt +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt @@ -7,6 +7,9 @@ Required properties: - #gpio-cells: Should be two. The first cell is the pin number and the second cell is used to specify flags. See ../gpio/gpio.txt for more information. + - xxx-in-supply: Phandle to parent supply node of each regulator + populated under regulators node. xxx can be + buck0, buck1, ldo0 or ldo1. - regulators: List of child nodes that specify the regulator initialization data. Example: @@ -17,6 +20,11 @@ pmic: lp8733@60 { gpio-controller; #gpio-cells = <2>; + buck0-in-supply = <&vsys_3v3>; + buck1-in-supply = <&vsys_3v3>; + ldo0-in-supply = <&vsys_3v3>; + ldo1-in-supply = <&vsys_3v3>; + regulators { lp8733_buck0: buck0 { regulator-name = "lp8733-buck0"; diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x-regulator.c index e504b91..70e3df6 100644 --- a/drivers/regulator/lp873x-regulator.c +++ b/drivers/regulator/lp873x-regulator.c @@ -24,6 +24,7 @@ [_id] = { \ .desc = { \ .name = _name, \ + .supply_name = _of "-in", \ .id = _id, \ .of_match = of_match_ptr(_of), \ .regulators_node = of_match_ptr("regulators"),\ -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lokeshvutla@ti.com (Lokesh Vutla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 4/9] regulator: lp873x: Add support for populating input supply Date: Wed, 2 Nov 2016 10:58:40 +0530 [thread overview] Message-ID: <e5619d78-5752-c8fb-8a11-6629c4b7c3f6@ti.com> (raw) In-Reply-To: <20161030204118.ojeetnxl5qsi6lp7@rob-hp-laptop> On Monday 31 October 2016 02:11 AM, Rob Herring wrote: > On Fri, Oct 21, 2016 at 04:08:36PM +0530, Lokesh Vutla wrote: >> In order to have a proper topology of regulators for a platform, each >> registering regulator needs to populate supply_name field for identifying >> its supply's name. Add supply_name field for lp873x regulators. >> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: Keerthy <j-keerthy@ti.com> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ >> drivers/regulator/lp873x-regulator.c | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt >> index 52766c2..998837a 100644 >> --- a/Documentation/devicetree/bindings/mfd/lp873x.txt >> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt >> @@ -7,6 +7,9 @@ Required properties: >> - #gpio-cells: Should be two. The first cell is the pin number and >> the second cell is used to specify flags. >> See ../gpio/gpio.txt for more information. >> + - xxx-in-supply: Phandle to parent supply node of each regulator >> + populated under regulators node. xxx should match >> + the supply_name populated in driver. > > The driver is irrelevant. This should reference a list in this document. okay. See if the below updated patch is fine. -----------------------------8<----------------------------8<---------------------------- >From 666f925423fa35c7bfcc77fa3c883cbea5d8ef8e Mon Sep 17 00:00:00 2001 From: Lokesh Vutla <lokeshvutla@ti.com> Date: Wed, 21 Sep 2016 11:50:49 +0530 Subject: [PATCH v3] regulator: lp873x: Add support for populating input supply In order to have a proper topology of regulators for a platform, each registering regulator needs to populate supply_name field for identifying its supply's name. Add supply_name field for lp873x regulators. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ drivers/regulator/lp873x-regulator.c | 1 + 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt index 52766c2..ae9cf39 100644 --- a/Documentation/devicetree/bindings/mfd/lp873x.txt +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt @@ -7,6 +7,9 @@ Required properties: - #gpio-cells: Should be two. The first cell is the pin number and the second cell is used to specify flags. See ../gpio/gpio.txt for more information. + - xxx-in-supply: Phandle to parent supply node of each regulator + populated under regulators node. xxx can be + buck0, buck1, ldo0 or ldo1. - regulators: List of child nodes that specify the regulator initialization data. Example: @@ -17,6 +20,11 @@ pmic: lp8733 at 60 { gpio-controller; #gpio-cells = <2>; + buck0-in-supply = <&vsys_3v3>; + buck1-in-supply = <&vsys_3v3>; + ldo0-in-supply = <&vsys_3v3>; + ldo1-in-supply = <&vsys_3v3>; + regulators { lp8733_buck0: buck0 { regulator-name = "lp8733-buck0"; diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x-regulator.c index e504b91..70e3df6 100644 --- a/drivers/regulator/lp873x-regulator.c +++ b/drivers/regulator/lp873x-regulator.c @@ -24,6 +24,7 @@ [_id] = { \ .desc = { \ .name = _name, \ + .supply_name = _of "-in", \ .id = _id, \ .of_match = of_match_ptr(_of), \ .regulators_node = of_match_ptr("regulators"),\ -- 2.10.1
next prev parent reply other threads:[~2016-11-02 5:28 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-21 10:38 [PATCH v2 0/9] ARM: DRA7: Add support for DRA718-evm Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla [not found] ` <20161021103841.8044-1-lokeshvutla-l0cyMroinI0@public.gmane.org> 2016-10-21 10:38 ` [PATCH v2 1/9] ARM: dts: dra72-evm: Remove pinmux configurations for erratum i869 Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 2/9] ARM: dra72-evm: Fix modelling of regulators Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 3/9] ARM: dts: dra72: Add separate dtsi for tps65917 Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla [not found] ` <20161021103841.8044-4-lokeshvutla-l0cyMroinI0@public.gmane.org> 2016-12-13 12:40 ` Roger Quadros 2016-12-13 12:40 ` Roger Quadros [not found] ` <045e8200-69bd-8590-1da4-96235444db4c-l0cyMroinI0@public.gmane.org> 2016-12-13 13:08 ` Lokesh Vutla 2016-12-13 13:08 ` Lokesh Vutla [not found] ` <91b4075f-2dfb-0d17-592d-f99b91ace590-l0cyMroinI0@public.gmane.org> 2016-12-13 14:55 ` Roger Quadros 2016-12-13 14:55 ` Roger Quadros 2016-10-21 10:38 ` [PATCH v2 4/9] regulator: lp873x: Add support for populating input supply Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla [not found] ` <20161021103841.8044-5-lokeshvutla-l0cyMroinI0@public.gmane.org> 2016-10-30 20:41 ` Rob Herring 2016-10-30 20:41 ` Rob Herring 2016-11-02 5:28 ` Lokesh Vutla [this message] 2016-11-02 5:28 ` Lokesh Vutla [not found] ` <e5619d78-5752-c8fb-8a11-6629c4b7c3f6-l0cyMroinI0@public.gmane.org> 2016-11-09 18:26 ` Rob Herring 2016-11-09 18:26 ` Rob Herring 2016-11-09 21:50 ` Tony Lindgren 2016-11-09 21:50 ` Tony Lindgren 2016-10-21 10:38 ` [PATCH v2 5/9] ARM: OMAP2+: board-generic: add support for DRA71x family Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 6/9] ARM: DRA7: hwmod: Do not register RTC on DRA71 Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 7/9] ARM: dts: Add support for dra718-evm Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 8/9] ARM: omap2plus_defconfig: Enable REGULATOR_GPIO Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-10-21 10:38 ` [PATCH v2 9/9] ARM: omap2plus_defconfig: Enable LP873X support Lokesh Vutla 2016-10-21 10:38 ` Lokesh Vutla 2016-11-07 3:49 ` [PATCH v2 0/9] ARM: DRA7: Add support for DRA718-evm Lokesh Vutla 2016-11-07 3:49 ` Lokesh Vutla [not found] ` <1b9c4d14-78d7-841f-776c-63a8c1ae1fb1-l0cyMroinI0@public.gmane.org> 2016-11-09 23:00 ` Tony Lindgren 2016-11-09 23:00 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e5619d78-5752-c8fb-8a11-6629c4b7c3f6@ti.com \ --to=lokeshvutla-l0cymroini0@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=j-keerthy-l0cyMroinI0@public.gmane.org \ --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nm-l0cyMroinI0@public.gmane.org \ --cc=nsekhar-l0cyMroinI0@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=t-kristo-l0cyMroinI0@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.