From: Sean Young <sean@mess.org> To: linux-media@vger.kernel.org, Matthias Reichl <hias@horus.com> Cc: Carlo Caione <carlo@caione.org>, Kevin Hilman <khilman@baylibre.com>, Heiner Kallweit <hkallweit1@gmail.com>, Neil Armstrong <narmstrong@baylibre.com>, Alex Deryskyba <alex@codesnake.com>, Jonas Karlman <jonas@kwiboo.se>, linux-amlogic@lists.infradead.org Subject: [PATCH v2 4/7] media: rc: mce_kbd decoder: low timeout values cause double keydowns Date: Sun, 8 Apr 2018 22:19:39 +0100 [thread overview] Message-ID: <e5bf02f1961fc60e84b74a76a0a7472f4029db26.1523221902.git.sean@mess.org> (raw) In-Reply-To: <cover.1523221902.git.sean@mess.org> In-Reply-To: <cover.1523221902.git.sean@mess.org> The mce keyboard repeats pressed keys every 100ms. If the IR timeout is set to less than that, we send key up events before the repeat arrives, so we have key up/key down for each IR repeat. The keyboard ends any sequence with a 0 scancode, in which case all keys are cleared so there is no need to run the timeout timer: it only exists for the case that the final 0 was not received. Signed-off-by: Sean Young <sean@mess.org> --- drivers/media/rc/ir-mce_kbd-decoder.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/rc/ir-mce_kbd-decoder.c b/drivers/media/rc/ir-mce_kbd-decoder.c index ae4b980c4a16..230b9397aa11 100644 --- a/drivers/media/rc/ir-mce_kbd-decoder.c +++ b/drivers/media/rc/ir-mce_kbd-decoder.c @@ -322,11 +322,13 @@ static int ir_mce_kbd_decode(struct rc_dev *dev, struct ir_raw_event ev) scancode = data->body & 0xffff; dev_dbg(&dev->dev, "keyboard data 0x%08x\n", data->body); - if (dev->timeout) - delay = usecs_to_jiffies(dev->timeout / 1000); - else - delay = msecs_to_jiffies(100); - mod_timer(&data->rx_timeout, jiffies + delay); + if (scancode) { + delay = nsecs_to_jiffies(dev->timeout) + + msecs_to_jiffies(100); + mod_timer(&data->rx_timeout, jiffies + delay); + } else { + del_timer(&data->rx_timeout); + } /* Pass data to keyboard buffer parser */ ir_mce_kbd_process_keyboard_data(dev, scancode); lsc.rc_proto = RC_PROTO_MCIR2_KBD; -- 2.14.3
WARNING: multiple messages have this Message-ID (diff)
From: sean@mess.org (Sean Young) To: linus-amlogic@lists.infradead.org Subject: [PATCH v2 4/7] media: rc: mce_kbd decoder: low timeout values cause double keydowns Date: Sun, 8 Apr 2018 22:19:39 +0100 [thread overview] Message-ID: <e5bf02f1961fc60e84b74a76a0a7472f4029db26.1523221902.git.sean@mess.org> (raw) In-Reply-To: <cover.1523221902.git.sean@mess.org> The mce keyboard repeats pressed keys every 100ms. If the IR timeout is set to less than that, we send key up events before the repeat arrives, so we have key up/key down for each IR repeat. The keyboard ends any sequence with a 0 scancode, in which case all keys are cleared so there is no need to run the timeout timer: it only exists for the case that the final 0 was not received. Signed-off-by: Sean Young <sean@mess.org> --- drivers/media/rc/ir-mce_kbd-decoder.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/rc/ir-mce_kbd-decoder.c b/drivers/media/rc/ir-mce_kbd-decoder.c index ae4b980c4a16..230b9397aa11 100644 --- a/drivers/media/rc/ir-mce_kbd-decoder.c +++ b/drivers/media/rc/ir-mce_kbd-decoder.c @@ -322,11 +322,13 @@ static int ir_mce_kbd_decode(struct rc_dev *dev, struct ir_raw_event ev) scancode = data->body & 0xffff; dev_dbg(&dev->dev, "keyboard data 0x%08x\n", data->body); - if (dev->timeout) - delay = usecs_to_jiffies(dev->timeout / 1000); - else - delay = msecs_to_jiffies(100); - mod_timer(&data->rx_timeout, jiffies + delay); + if (scancode) { + delay = nsecs_to_jiffies(dev->timeout) + + msecs_to_jiffies(100); + mod_timer(&data->rx_timeout, jiffies + delay); + } else { + del_timer(&data->rx_timeout); + } /* Pass data to keyboard buffer parser */ ir_mce_kbd_process_keyboard_data(dev, scancode); lsc.rc_proto = RC_PROTO_MCIR2_KBD; -- 2.14.3
next prev parent reply other threads:[~2018-04-08 21:19 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-08 21:19 [PATCH v2 0/7] Improve latency of IR decoding Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` [PATCH v2 1/7] media: rc: set timeout to smallest value required by enabled protocols Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` [PATCH v2 2/7] media: rc: add ioctl to get the current timeout Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` [PATCH v2 3/7] media: rc: per-protocol repeat period and minimum keyup timer Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` Sean Young [this message] 2018-04-08 21:19 ` [PATCH v2 4/7] media: rc: mce_kbd decoder: low timeout values cause double keydowns Sean Young 2018-04-08 21:19 ` [PATCH v2 5/7] media: rc: mce_kbd protocol encodes two scancodes Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` [PATCH v2 6/7] media: rc: mce_kbd decoder: fix stuck keys Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-08 21:19 ` [PATCH v2 7/7] media: rc: mceusb: allow the timeout to be configurable Sean Young 2018-04-08 21:19 ` Sean Young 2018-04-17 19:14 ` Matthias Reichl 2018-04-17 19:14 ` Matthias Reichl 2018-04-18 11:24 ` Sean Young 2018-04-18 11:24 ` Sean Young 2018-04-18 17:42 ` Matthias Reichl 2018-04-18 17:42 ` Matthias Reichl 2018-04-19 22:17 ` Matthias Reichl 2018-04-19 22:17 ` Matthias Reichl 2018-04-21 13:18 ` Matthias Reichl 2018-04-21 13:18 ` Matthias Reichl 2018-04-21 17:41 ` Matthias Reichl 2018-04-21 17:41 ` Matthias Reichl 2018-05-07 15:54 ` Matthias Reichl 2018-05-09 21:44 ` Sean Young 2018-05-10 11:01 ` Matthias Reichl 2018-05-13 11:34 ` Matthias Reichl 2018-04-10 17:53 ` [PATCH v2 0/7] Improve latency of IR decoding Matthias Reichl 2018-04-10 17:53 ` Matthias Reichl 2018-04-10 18:39 ` Sean Young 2018-04-10 18:39 ` Sean Young 2018-04-10 19:24 ` Matthias Reichl 2018-04-10 19:24 ` Matthias Reichl 2018-04-12 22:02 ` Sean Young 2018-04-12 22:02 ` Sean Young
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e5bf02f1961fc60e84b74a76a0a7472f4029db26.1523221902.git.sean@mess.org \ --to=sean@mess.org \ --cc=alex@codesnake.com \ --cc=carlo@caione.org \ --cc=hias@horus.com \ --cc=hkallweit1@gmail.com \ --cc=jonas@kwiboo.se \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=narmstrong@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.