All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 1/7] x86: correct comment about alternatives ordering
Date: Tue, 27 Apr 2021 14:53:08 +0200	[thread overview]
Message-ID: <e6f362b3-2339-c5cb-362b-743271dbe826@suse.com> (raw)
In-Reply-To: <6d6da76c-ccc8-afa2-bd06-5ae132c354f2@suse.com>

Unlike Linux, Xen has never (so far) used alternatives patching for
memcpy() or memset(), even less such utilizing multiple alternatives.
Correct the Linux-inherited comment to match reality.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -194,8 +194,7 @@ static void init_or_livepatch _apply_alt
     /*
      * The scan order should be from start to end. A later scanned
      * alternative code can overwrite a previous scanned alternative code.
-     * Some kernel functions (e.g. memcpy, memset, etc) use this order to
-     * patch code.
+     * Some code (e.g. ALTERNATIVE_2()) relies on this order of patching.
      *
      * So be careful if you want to change the scan order to any other
      * order.



  reply	other threads:[~2021-04-27 12:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 12:51 [PATCH 0/7] x86: memcpy() / memset() (non-)ERMS flavors plus fallout Jan Beulich
2021-04-27 12:53 ` Jan Beulich [this message]
2021-04-27 13:19   ` [PATCH 1/7] x86: correct comment about alternatives ordering Andrew Cooper
2021-04-27 12:54 ` [PATCH 2/7] x86: introduce ioremap_wc() Jan Beulich
2021-04-27 17:13   ` Andrew Cooper
2021-04-28  9:41     ` Jan Beulich
2021-04-27 12:54 ` [PATCH 3/7] x86: re-work memset() Jan Beulich
2021-04-27 12:54 ` [PATCH 4/7] x86: re-work memcpy() Jan Beulich
2021-04-27 12:55 ` [PATCH 5/7] video/vesa: unmap frame buffer when relinquishing console Jan Beulich
2021-04-27 12:56 ` [PATCH 6/7] video/vesa: drop "vesa-mtrr" command line option Jan Beulich
2021-04-27 13:20   ` Andrew Cooper
2021-04-27 12:56 ` [PATCH 7/7] video/vesa: adjust (not just) command line option handling Jan Beulich
2021-04-27 13:49   ` Andrew Cooper
2021-04-27 14:04     ` Jan Beulich
2021-05-27 11:47       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6f362b3-2339-c5cb-362b-743271dbe826@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.