From: Viresh Kumar <viresh.kumar@linaro.org> To: pjt@google.com, paul.mckenney@linaro.org, tglx@linutronix.de, tj@kernel.org, suresh.b.siddha@intel.com, venki@google.com, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org Cc: linaro-kernel@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, Arvind.Chauhan@arm.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>, Dave Airlie <airlied@redhat.com>, linux-fbdev@vger.kernel.org Subject: [PATCH V3 7/7] fbcon: queue work on any cpu Date: Mon, 18 Mar 2013 20:53:29 +0530 [thread overview] Message-ID: <e82c429f56d058cb6e2bbcad40232c11a4be511a.1363617402.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1363617402.git.viresh.kumar@linaro.org> In-Reply-To: <cover.1363617402.git.viresh.kumar@linaro.org> fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up few times just to service this work. It would be better if we can schedule it on a cpu which isn't idle to save on power. By idle cpu (from scheduler's perspective) we mean: - Current task is idle task - nr_running == 0 - wake_list is empty This patch replaces schedule_work() routine with queue_work_on_any_cpu() sibling with system_wq as workqueue. This routine would look for the closest (via scheduling domains) non-idle cpu (non-idle from schedulers perspective). If the current cpu is not idle or all cpus are idle, work will be scheduled on local cpu. Cc: Dave Airlie <airlied@redhat.com> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..a900997 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work_on_any_cpu(system_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); } -- 1.7.12.rc2.18.g61b472e
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: pjt@google.com, paul.mckenney@linaro.org, tglx@linutronix.de, tj@kernel.org, suresh.b.siddha@intel.com, venki@google.com, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org Cc: linaro-kernel@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, Arvind.Chauhan@arm.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>, Dave Airlie <airlied@redhat.com>, linux-fbdev@vger.kernel.org Subject: [PATCH V3 7/7] fbcon: queue work on any cpu Date: Mon, 18 Mar 2013 15:35:29 +0000 [thread overview] Message-ID: <e82c429f56d058cb6e2bbcad40232c11a4be511a.1363617402.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1363617402.git.viresh.kumar@linaro.org> fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up few times just to service this work. It would be better if we can schedule it on a cpu which isn't idle to save on power. By idle cpu (from scheduler's perspective) we mean: - Current task is idle task - nr_running = 0 - wake_list is empty This patch replaces schedule_work() routine with queue_work_on_any_cpu() sibling with system_wq as workqueue. This routine would look for the closest (via scheduling domains) non-idle cpu (non-idle from schedulers perspective). If the current cpu is not idle or all cpus are idle, work will be scheduled on local cpu. Cc: Dave Airlie <airlied@redhat.com> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..a900997 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work_on_any_cpu(system_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); } -- 1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2013-03-18 15:25 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-18 15:23 [PATCH V3 0/7] Create sched_select_cpu() and use it for workqueues Viresh Kumar 2013-03-18 15:23 ` [PATCH V3 1/7] sched: Create sched_select_cpu() to give preferred CPU for power saving Viresh Kumar 2013-03-18 15:39 ` Frederic Weisbecker 2013-03-18 15:44 ` Viresh Kumar 2013-03-18 15:57 ` Frederic Weisbecker 2013-03-19 5:15 ` Viresh Kumar 2013-03-19 5:15 ` Viresh Kumar 2013-03-19 12:30 ` Peter Zijlstra 2013-03-19 12:52 ` Viresh Kumar 2013-03-19 13:22 ` Viresh Kumar 2013-03-18 15:23 ` [PATCH V3 2/7] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target() Viresh Kumar 2013-03-18 15:23 ` [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu Viresh Kumar 2013-03-19 5:15 ` Viresh Kumar 2013-03-19 13:23 ` Viresh Kumar 2013-03-21 0:12 ` Tejun Heo 2013-03-21 10:57 ` Viresh Kumar 2013-03-21 18:29 ` Tejun Heo 2013-03-28 18:13 ` Tejun Heo 2013-03-29 2:39 ` Viresh Kumar 2013-03-29 7:27 ` Viresh Kumar 2013-03-29 17:40 ` Tejun Heo 2013-03-29 17:56 ` Tejun Heo 2013-03-30 3:30 ` Viresh Kumar 2013-03-18 15:23 ` [PATCH V3 4/7] PHYLIB: queue " Viresh Kumar 2013-03-18 17:33 ` David Miller 2013-03-18 15:23 ` [PATCH V3 5/7] mmc: " Viresh Kumar 2013-03-19 7:58 ` Ulf Hansson 2013-03-22 17:09 ` Chris Ball 2013-03-22 17:26 ` Chris Ball 2013-03-22 17:27 ` Viresh Kumar 2013-03-22 17:30 ` Chris Ball 2013-03-18 15:23 ` [PATCH V3 6/7] block: " Viresh Kumar 2013-03-22 15:05 ` Jens Axboe 2013-03-23 6:44 ` Viresh Kumar 2013-03-18 15:23 ` Viresh Kumar [this message] 2013-03-18 15:35 ` [PATCH V3 7/7] fbcon: " Viresh Kumar 2013-03-19 5:00 ` [PATCH V3 0/7] Create sched_select_cpu() and use it for workqueues Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e82c429f56d058cb6e2bbcad40232c11a4be511a.1363617402.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=Arvind.Chauhan@arm.com \ --cc=Liviu.Dudau@arm.com \ --cc=Steve.Bannister@arm.com \ --cc=airlied@redhat.com \ --cc=charles.garcia-tobin@arm.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rt-users@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=paul.mckenney@linaro.org \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=robin.randhawa@arm.com \ --cc=rostedt@goodmis.org \ --cc=suresh.b.siddha@intel.com \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=venki@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.