From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: Anand Jain <anand.jain@oracle.com>
Subject: [PATCH] btrfs: validate device maj:min during scan
Date: Tue, 12 Mar 2024 18:32:41 +0530 [thread overview]
Message-ID: <ea6a2384807500090943f95c164e9f6b899efc58.1710246349.git.anand.jain@oracle.com> (raw)
The maj:min of a device can change without altering the device path.
When the device is re-scanned, only the device path change is fixed,
if any, but the changed maj:min remains (bug). This patch fixes it by
also checking for the changed maj:min.
However, please note that we still need to validate the maj:min during
open as in the patch ("btrfs: validate device maj:min during open") because
only the device specified in the mount command gets scanned during mount.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 8a35605822bf..473f03965f26 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -854,7 +854,8 @@ static noinline struct btrfs_device *device_list_add(const char *path,
MAJOR(path_devt), MINOR(path_devt),
current->comm, task_pid_nr(current));
- } else if (!device->name || strcmp(device->name->str, path)) {
+ } else if (!device->name || strcmp(device->name->str, path) ||
+ device->devt != path_devt) {
/*
* When FS is already mounted.
* 1. If you are here and if the device->name is NULL that
--
2.31.1
next reply other threads:[~2024-03-12 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 13:02 Anand Jain [this message]
2024-03-12 19:14 ` [PATCH] btrfs: validate device maj:min during scan Boris Burkov
2024-03-12 23:32 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6a2384807500090943f95c164e9f6b899efc58.1710246349.git.anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.