All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
	xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
	consulting@bugseng.com, jbeulich@suse.com,
	andrew.cooper3@citrix.com, roger.pau@citrix.com,
	bertrand.marquis@arm.com, julien@xen.org,
	George Dunlap <george.dunlap@citrix.com>
Subject: [XEN PATCH 07/11] xen/page_alloc: address violations of MISRA C Rule 20.7
Date: Fri, 22 Mar 2024 17:01:56 +0100	[thread overview]
Message-ID: <ead692e7a9f7f21ae54448073af8b64a40f2ddfe.1711118582.git.nicola.vetrini@bugseng.com> (raw)
In-Reply-To: <cover.1711118582.git.nicola.vetrini@bugseng.com>

MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
 xen/common/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 28c510d6669b..82dc55829f78 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -150,7 +150,7 @@
 #include <asm/paging.h>
 #else
 #define p2m_pod_offline_or_broken_hit(pg) 0
-#define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
+#define p2m_pod_offline_or_broken_replace(pg) BUG_ON((pg) != NULL)
 #endif
 
 #ifndef PGC_static
-- 
2.34.1



  parent reply	other threads:[~2024-03-22 16:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 16:01 [XEN PATCH 00/11] address some violations of MISRA C Rule 20.7 Nicola Vetrini
2024-03-22 16:01 ` [XEN PATCH 01/11] xen/list: address " Nicola Vetrini
2024-03-25  9:19   ` Jan Beulich
2024-03-22 16:01 ` [XEN PATCH 02/11] xen/xsm: add parentheses to comply with " Nicola Vetrini
2024-03-23  1:29   ` Daniel P. Smith
2024-03-22 16:01 ` [XEN PATCH 03/11] xen/efi: efibind: address violations of " Nicola Vetrini
2024-03-22 16:01 ` [XEN PATCH 04/11] xentrace: address violation " Nicola Vetrini
2024-03-25  9:20   ` Jan Beulich
2024-03-22 16:01 ` [XEN PATCH 05/11] xen: address MISRA C Rule 20.7 violation in generated hypercall Nicola Vetrini
2024-03-25  9:23   ` Jan Beulich
2024-03-22 16:01 ` [XEN PATCH 06/11] xen/efi: address violations of MISRA C Rule 20.7 Nicola Vetrini
2024-03-25  9:25   ` Jan Beulich
2024-03-25 13:07     ` Nicola Vetrini
2024-03-22 16:01 ` Nicola Vetrini [this message]
2024-03-25  9:27   ` [XEN PATCH 07/11] xen/page_alloc: " Jan Beulich
2024-03-26 15:27     ` Nicola Vetrini
2024-03-26 15:35       ` Jan Beulich
2024-03-26 15:57         ` Nicola Vetrini
2024-03-22 16:01 ` [XEN PATCH 08/11] x86/altcall: " Nicola Vetrini
2024-03-25  9:38   ` Jan Beulich
2024-03-25 14:47     ` Nicola Vetrini
2024-03-25 14:58       ` Jan Beulich
2024-03-26 10:30         ` Nicola Vetrini
2024-03-22 16:01 ` [XEN PATCH 09/11] x86/msi: address violation of MISRA C Rule 20.7 and coding style Nicola Vetrini
2024-03-26 10:05   ` Jan Beulich
2024-03-26 14:30     ` Nicola Vetrini
2024-03-26 15:13       ` Jan Beulich
2024-03-26 15:41         ` Nicola Vetrini
2024-03-26 16:06           ` Nicola Vetrini
2024-03-22 16:01 ` [XEN PATCH 10/11] x86/hvm: address violations of Rule 20.7 Nicola Vetrini
2024-03-26 10:13   ` Jan Beulich
2024-03-26 14:31     ` Nicola Vetrini
2024-03-22 16:02 ` [XEN PATCH 11/11] x86/public: hvm: address violations of MISRA C " Nicola Vetrini
2024-03-26 10:15   ` Jan Beulich
2024-03-26 14:34     ` Nicola Vetrini
2024-03-27  8:18   ` Jan Beulich
2024-03-25  8:00 ` [XEN PATCH 00/11] address some " Jan Beulich
2024-03-25  8:07   ` Nicola Vetrini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ead692e7a9f7f21ae54448073af8b64a40f2ddfe.1711118582.git.nicola.vetrini@bugseng.com \
    --to=nicola.vetrini@bugseng.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ayan.kumar.halder@amd.com \
    --cc=bertrand.marquis@arm.com \
    --cc=consulting@bugseng.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xenia.ragiadakou@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.