From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <Mario.Limonciello@amd.com>,
<viresh.kumar@linaro.org>, <Ray.Huang@amd.com>,
<gautham.shenoy@amd.com>, <Borislav.Petkov@amd.com>
Cc: <Alexander.Deucher@amd.com>, <Xinmei.Huang@amd.com>,
<Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/6] cpufreq:amd-pstate: fix the nominal freq value set
Date: Fri, 2 Feb 2024 16:55:34 +0800 [thread overview]
Message-ID: <ebbe3741501a31b1ffcea208393cdd8929df6455.1706863981.git.perry.yuan@amd.com> (raw)
In-Reply-To: <cover.1706863981.git.perry.yuan@amd.com>
Address an untested error where the nominal_freq was returned in KHz
instead of the correct MHz units, this oversight led to a wrong
nominal_freq set and resued, it will cause the max frequency of core to
be initialized with a wrong frequency value.
Cc: stable@vger.kernel.org
Fixes: ec437d71db7 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Perry Yuan <perry.yuan@amd.com>
---
drivers/cpufreq/amd-pstate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 08e112444c27..ac7faa98a450 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -640,8 +640,7 @@ static int amd_get_nominal_freq(struct amd_cpudata *cpudata)
if (ret)
return ret;
- /* Switch to khz */
- return cppc_perf.nominal_freq * 1000;
+ return cppc_perf.nominal_freq;
}
static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
--
2.34.1
next prev parent reply other threads:[~2024-02-02 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 8:55 [PATCH v2 0/6] AMD Pstate Fixes And Enhancements Perry Yuan
2024-02-02 8:55 ` [PATCH v2 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors Perry Yuan
2024-02-02 8:55 ` Perry Yuan [this message]
2024-02-02 8:55 ` [PATCH v2 3/6] cpufreq:amd-pstate: initialize nominal_freq of each cpudata Perry Yuan
2024-02-02 8:55 ` [PATCH v2 4/6] cpufreq:amd-pstate: get pstate transition delay and latency value from ACPI tables Perry Yuan
2024-02-02 8:55 ` [PATCH v2 5/6] cppc_acpi: print error message if CPPC is unsupported Perry Yuan
2024-02-02 15:17 ` Mario Limonciello
2024-02-02 8:55 ` [PATCH v2 6/6] cpufreq:amd-pstate: add quirk for the pstate CPPC capabilities missing Perry Yuan
2024-02-02 15:16 ` Mario Limonciello
2024-02-02 15:35 ` Yuan, Perry
2024-02-02 15:55 ` Mario Limonciello
2024-02-02 16:27 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebbe3741501a31b1ffcea208393cdd8929df6455.1706863981.git.perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.