From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Paul Durrant" <paul@xen.org>
Subject: [PATCH v2 12/12] PCI/ATS: tidy {en,dis}able_ats_device() a little
Date: Thu, 15 Feb 2024 11:19:46 +0100 [thread overview]
Message-ID: <edec0260-e338-49aa-a21f-c507ef9e35cb@suse.com> (raw)
In-Reply-To: <64b028be-2197-4951-ae5b-32f9eabfa84a@suse.com>
Use appropriate types for the control register value as well as the
capability position. Constify a pointer. Use "else" in favor of encoding
the opposite condition of the earlier if().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.
--- a/xen/drivers/passthrough/ats.c
+++ b/xen/drivers/passthrough/ats.c
@@ -23,10 +23,9 @@ boolean_param("ats", opt_ats);
int enable_ats_device(struct pci_dev *pdev, struct list_head *ats_list)
{
- u32 value;
- int pos;
+ uint16_t value;
+ unsigned int pos = pci_find_ext_capability(pdev->sbdf, PCI_EXT_CAP_ID_ATS);
- pos = pci_find_ext_capability(pdev->sbdf, PCI_EXT_CAP_ID_ATS);
BUG_ON(!pos);
if ( iommu_verbose )
@@ -35,7 +34,7 @@ int enable_ats_device(struct pci_dev *pd
value = pci_conf_read16(pdev->sbdf, pos + ATS_REG_CTL);
if ( value & ATS_ENABLE )
{
- struct pci_dev *other;
+ const struct pci_dev *other;
list_for_each_entry ( other, ats_list, ats.list )
if ( other == pdev )
@@ -44,8 +43,7 @@ int enable_ats_device(struct pci_dev *pd
break;
}
}
-
- if ( !(value & ATS_ENABLE) )
+ else
{
value |= ATS_ENABLE;
pci_conf_write16(pdev->sbdf, pos + ATS_REG_CTL, value);
@@ -69,7 +67,7 @@ int enable_ats_device(struct pci_dev *pd
void disable_ats_device(struct pci_dev *pdev)
{
- u32 value;
+ uint16_t value;
BUG_ON(!pdev->ats.cap_pos);
next prev parent reply other threads:[~2024-02-15 10:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 10:11 [PATCH v2 00/12] VT-d: SATC handling; ATS: tidying Jan Beulich
2024-02-15 10:13 ` [PATCH v2 01/12] VT-d: correct ATS checking for root complex integrated devices Jan Beulich
2024-05-03 14:01 ` Roger Pau Monné
2024-02-15 10:14 ` [PATCH v2 02/12] VT-d: tidy error handling of RMRR parsing Jan Beulich
2024-05-06 9:12 ` Roger Pau Monné
2024-05-06 9:21 ` Jan Beulich
2024-05-06 9:26 ` Roger Pau Monné
2024-02-15 10:14 ` [PATCH v2 03/12] VT-d: parse ACPI "SoC Integrated Address Translation Cache Reporting Structure"s Jan Beulich
2024-05-06 10:29 ` Roger Pau Monné
2024-05-06 11:01 ` Jan Beulich
2024-05-06 11:09 ` Roger Pau Monné
2024-02-15 10:15 ` [PATCH v2 04/12] AMD/IOMMU: add helper to check whether ATS is to be used for a device Jan Beulich
2024-05-06 11:27 ` Roger Pau Monné
2024-02-15 10:15 ` [PATCH v2 05/12] IOMMU: rename and re-type ats_enabled Jan Beulich
2024-02-15 10:21 ` Jan Beulich
2024-05-06 12:42 ` Roger Pau Monné
2024-05-06 13:20 ` Jan Beulich
2024-05-06 13:53 ` Roger Pau Monné
2024-02-15 10:16 ` [PATCH v2 06/12] VT-d: respect ACPI SATC's ATC_REQUIRED flag Jan Beulich
2024-05-06 13:38 ` Roger Pau Monné
2024-02-15 10:16 ` [PATCH v2 07/12] VT-d: replace find_ats_dev_drhd() Jan Beulich
2024-02-15 10:17 ` [PATCH v2 08/12] VT-d: move ats_device() to the sole file it's used from Jan Beulich
2024-02-15 10:18 ` [PATCH v2 09/12] VT-d: move dev_invalidate_iotlb() " Jan Beulich
2024-02-15 10:18 ` [PATCH v2 10/12] VT-d: move {,un}map_vtd_domain_page() Jan Beulich
2024-02-15 10:18 ` [PATCH v2 11/12] VT-d: drop flush_dev_iotlb parameter from IOTLB flush hook Jan Beulich
2024-05-06 14:06 ` Roger Pau Monné
2024-02-15 10:19 ` Jan Beulich [this message]
2024-05-06 14:10 ` [PATCH v2 12/12] PCI/ATS: tidy {en,dis}able_ats_device() a little Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edec0260-e338-49aa-a21f-c507ef9e35cb@suse.com \
--to=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.