Re: [PATCH] Atmel AT42QT2160 sensor chip input driver

[Raphael Derosso Pereira <raphaelpereira@gmail.com>]

Hello Dmitry,

I managed to get a working copy of your 'for-linus' branch.

I compiled and tested it and it is working fine! I would just remove
the first #include <autoconf.h> as it was only added for the
CONFIG_QT2160_DEBUG you removed.

Also, this chip is capable of performing some ajustments, like adding
keys to groups to avoid double detection, setting up sensibility,
detection thresholds, etc... I was wondering how to put that to
userspace, through sysfs, evdev ioctl or a /dev entry. What do you
suggest???

--
From: Raphael Derosso Pereira <raphaelpereira@gmail.com>

Inclusion cleanup

Signed-off-by: Raphael Derosso Pereira <raphaelpereira@gmail.com>
--
diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c
index 0d57c17..191cc51 100644
--- a/drivers/input/keyboard/qt2160.c
+++ b/drivers/input/keyboard/qt2160.c
@@ -18,8 +18,6 @@
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */

-#include <linux/autoconf.h>
-
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/module.h>


2009/9/22 Raphael Derosso Pereira <raphaelpereira@gmail.com>:
> Hello,
>
> 2009/9/22 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>> Hi Raphael,
>>
>>
>> I don't think we need a Kconfig entry for debugging. A person who wants
>> to debug such driver can easily turn on debugging manually.
>
> Ok.
>
>>
>> We normally try to allocate all necessary resources in probe() so that
>> if device is bound to a driver it should work unless it is broken. Since
>> there is no way to shut off IRQs while IRQ handler is registered it does
>> not make sense to have open and close if we allocate IRQ in probe().
>
> Agreed.
>
>>
>> Please take a look at the latest version that I have in 'for-linus'
>> branch in my tree on kernel.org and shout if you see something wrong.
>
> How am I supposed to do that?
>
>>
>> Thanks.
>>
>> --
>> Dmitry
>>
>
>
>
> --
> Raphael Derosso Pereira
> Engenheiro de Computação
> msn: rderossopereira@hotmail.com
> Skype: rderossopereira
>



-- 
Raphael Derosso Pereira
Engenheiro de Computação
msn: rderossopereira@hotmail.com
Skype: rderossopereira
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html