From: Omar Sandoval <osandov@osandov.com> To: linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk> Cc: kernel-team@fb.com, linux-api@vger.kernel.org, David Howells <dhowells@redhat.com>, Amir Goldstein <amir73il@gmail.com>, Xi Wang <xi@cs.washington.edu>, fstests@vger.kernel.org Subject: [RFC PATCH xfstests] generic: add smoke test for AT_LINK_REPLACE Date: Wed, 29 Jan 2020 00:58:27 -0800 [thread overview] Message-ID: <f23621bea2e8d5f919389131b84fa0226b90f502.1580253372.git.osandov@fb.com> (raw) In-Reply-To: <cover.1580251857.git.osandov@fb.com> From: Omar Sandoval <osandov@fb.com> Cc: fstests@vger.kernel.org Signed-off-by: Omar Sandoval <osandov@fb.com> --- common/rc | 2 +- tests/generic/593 | 97 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/593.out | 6 +++ tests/generic/group | 1 + 4 files changed, 105 insertions(+), 1 deletion(-) create mode 100755 tests/generic/593 create mode 100644 tests/generic/593.out diff --git a/common/rc b/common/rc index eeac1355..257f65a1 100644 --- a/common/rc +++ b/common/rc @@ -2172,7 +2172,7 @@ _require_xfs_io_command() ;; "flink") local testlink=$TEST_DIR/$$.link.xfs_io - testio=`$XFS_IO_PROG -F -f -c "flink $testlink" $testfile 2>&1` + testio=`$XFS_IO_PROG -F -f -c "flink $param $testlink" $testfile 2>&1` rm -f $testlink > /dev/null 2>&1 ;; "-T") diff --git a/tests/generic/593 b/tests/generic/593 new file mode 100755 index 00000000..8a9fee02 --- /dev/null +++ b/tests/generic/593 @@ -0,0 +1,97 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Facebook. All Rights Reserved. +# +# FS QA Test 593 +# +# Smoke test linkat() with AT_LINK_REPLACE. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +_supported_fs generic +_supported_os Linux +_require_test +_require_xfs_io_command "-T" +_require_xfs_io_command "flink" "-f" + +same_file() { + [[ "$(stat -c '%d %i' "$1")" = "$(stat -c '%d %i' "$2")" ]] +} + +touch "$TEST_DIR/$seq.src" +touch "$TEST_DIR/$seq.tgt" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" || + echo "Target was not replaced" + +# Linking to the same file should be a noop. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.src" "$TEST_DIR/$seq.src" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" || echo "Target changed?" + +# Should work with O_TMPFILE. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" -T "$TEST_DIR" +stat -c '%h' "$TEST_DIR/$seq.tgt" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" && + echo "Target was not replaced" + +# It's okay if the target doesn't exist. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt2" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt2" || + echo "Target was not created" + +# Can't replace directories. +mkdir "$TEST_DIR/$seq.dir" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.dir" "$TEST_DIR/$seq.src" +cd "$TEST_DIR/$seq.dir" +$XFS_IO_PROG -c "flink -f ." "$TEST_DIR/$seq.src" +$XFS_IO_PROG -c "flink -f .." "$TEST_DIR/$seq.src" +cd - &> /dev/null + +# Can't replace local mount points. +touch "$TEST_DIR/$seq.mnt" +$MOUNT_PROG --bind "$TEST_DIR/$seq.mnt" "$TEST_DIR/$seq.mnt" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.mnt" "$TEST_DIR/$seq.src" + +# Can replace mount points in other namespaces, though. +unshare -m \ + bash -c "$UMOUNT_PROG $TEST_DIR/$seq.mnt; $XFS_IO_PROG -c \"flink -f $TEST_DIR/$seq.mnt\" $TEST_DIR/$seq.src" +if $UMOUNT_PROG "$TEST_DIR/$seq.mnt" &> /dev/null; then + echo "Mount point was not detached" +fi +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.mnt" || + echo "Mount point was not replaced" + +# Should replace symlinks, not follow them. +touch "$TEST_DIR/$seq.symtgt" +ln -s "$TEST_DIR/$seq.symtgt" "$TEST_DIR/$seq.sym" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.sym" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.sym" || + echo "Symlink was not replaced" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.symtgt" && + echo "Symlink target was replaced" + +rm -rf "$TEST_DIR/$seq."* + +status=0 +exit diff --git a/tests/generic/593.out b/tests/generic/593.out new file mode 100644 index 00000000..834c34bf --- /dev/null +++ b/tests/generic/593.out @@ -0,0 +1,6 @@ +QA output created by 593 +1 +flink: Is a directory +flink: Is a directory +flink: Is a directory +flink: Device or resource busy diff --git a/tests/generic/group b/tests/generic/group index 6fe62505..0a87efca 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -595,3 +595,4 @@ 590 auto prealloc preallocrw 591 auto quick rw pipe splice 592 auto quick encrypt +593 auto quick hardlink -- 2.25.0
WARNING: multiple messages have this Message-ID (diff)
From: Omar Sandoval <osandov@osandov.com> To: linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk> Cc: kernel-team@fb.com Subject: [RFC PATCH xfstests] generic: add smoke test for AT_LINK_REPLACE Date: Tue, 28 Jan 2020 15:18:56 -0800 [thread overview] Message-ID: <f23621bea2e8d5f919389131b84fa0226b90f502.1580253372.git.osandov@fb.com> (raw) In-Reply-To: <cover.1580251857.git.osandov@fb.com> From: Omar Sandoval <osandov@fb.com> Signed-off-by: Omar Sandoval <osandov@fb.com> --- common/rc | 2 +- tests/generic/593 | 97 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/593.out | 6 +++ tests/generic/group | 1 + 4 files changed, 105 insertions(+), 1 deletion(-) create mode 100755 tests/generic/593 create mode 100644 tests/generic/593.out diff --git a/common/rc b/common/rc index eeac1355..257f65a1 100644 --- a/common/rc +++ b/common/rc @@ -2172,7 +2172,7 @@ _require_xfs_io_command() ;; "flink") local testlink=$TEST_DIR/$$.link.xfs_io - testio=`$XFS_IO_PROG -F -f -c "flink $testlink" $testfile 2>&1` + testio=`$XFS_IO_PROG -F -f -c "flink $param $testlink" $testfile 2>&1` rm -f $testlink > /dev/null 2>&1 ;; "-T") diff --git a/tests/generic/593 b/tests/generic/593 new file mode 100755 index 00000000..8a9fee02 --- /dev/null +++ b/tests/generic/593 @@ -0,0 +1,97 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Facebook. All Rights Reserved. +# +# FS QA Test 593 +# +# Smoke test linkat() with AT_LINK_REPLACE. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +_supported_fs generic +_supported_os Linux +_require_test +_require_xfs_io_command "-T" +_require_xfs_io_command "flink" "-f" + +same_file() { + [[ "$(stat -c '%d %i' "$1")" = "$(stat -c '%d %i' "$2")" ]] +} + +touch "$TEST_DIR/$seq.src" +touch "$TEST_DIR/$seq.tgt" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" || + echo "Target was not replaced" + +# Linking to the same file should be a noop. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.src" "$TEST_DIR/$seq.src" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" || echo "Target changed?" + +# Should work with O_TMPFILE. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt" -T "$TEST_DIR" +stat -c '%h' "$TEST_DIR/$seq.tgt" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt" && + echo "Target was not replaced" + +# It's okay if the target doesn't exist. +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.tgt2" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.tgt2" || + echo "Target was not created" + +# Can't replace directories. +mkdir "$TEST_DIR/$seq.dir" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.dir" "$TEST_DIR/$seq.src" +cd "$TEST_DIR/$seq.dir" +$XFS_IO_PROG -c "flink -f ." "$TEST_DIR/$seq.src" +$XFS_IO_PROG -c "flink -f .." "$TEST_DIR/$seq.src" +cd - &> /dev/null + +# Can't replace local mount points. +touch "$TEST_DIR/$seq.mnt" +$MOUNT_PROG --bind "$TEST_DIR/$seq.mnt" "$TEST_DIR/$seq.mnt" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.mnt" "$TEST_DIR/$seq.src" + +# Can replace mount points in other namespaces, though. +unshare -m \ + bash -c "$UMOUNT_PROG $TEST_DIR/$seq.mnt; $XFS_IO_PROG -c \"flink -f $TEST_DIR/$seq.mnt\" $TEST_DIR/$seq.src" +if $UMOUNT_PROG "$TEST_DIR/$seq.mnt" &> /dev/null; then + echo "Mount point was not detached" +fi +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.mnt" || + echo "Mount point was not replaced" + +# Should replace symlinks, not follow them. +touch "$TEST_DIR/$seq.symtgt" +ln -s "$TEST_DIR/$seq.symtgt" "$TEST_DIR/$seq.sym" +$XFS_IO_PROG -c "flink -f $TEST_DIR/$seq.sym" "$TEST_DIR/$seq.src" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.sym" || + echo "Symlink was not replaced" +same_file "$TEST_DIR/$seq.src" "$TEST_DIR/$seq.symtgt" && + echo "Symlink target was replaced" + +rm -rf "$TEST_DIR/$seq."* + +status=0 +exit diff --git a/tests/generic/593.out b/tests/generic/593.out new file mode 100644 index 00000000..834c34bf --- /dev/null +++ b/tests/generic/593.out @@ -0,0 +1,6 @@ +QA output created by 593 +1 +flink: Is a directory +flink: Is a directory +flink: Is a directory +flink: Device or resource busy diff --git a/tests/generic/group b/tests/generic/group index 6fe62505..0a87efca 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -595,3 +595,4 @@ 590 auto prealloc preallocrw 591 auto quick rw pipe splice 592 auto quick encrypt +593 auto quick hardlink -- 2.25.0
next prev parent reply other threads:[~2020-01-29 8:58 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-28 23:18 [RFC PATCH v4 0/4] fs: add flag to linkat() for replacing destination Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-28 23:18 ` Omar Sandoval [this message] 2020-01-29 8:58 ` [RFC PATCH xfstests] generic: add smoke test for AT_LINK_REPLACE Omar Sandoval 2020-01-29 7:02 ` Zorro Lang 2020-02-23 14:46 ` Eryu Guan 2020-01-28 23:18 ` [RFC PATCH man-pages] link.2: Document new AT_LINK_REPLACE flag Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-28 23:18 ` [RFC PATCH xfsprogs] xfs_io: add support for linkat() AT_LINK_REPLACE Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-30 4:42 ` Zorro Lang 2020-01-28 23:19 ` [RFC PATCH v4 1/4] fs: add flags argument to i_op->link() Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-28 23:19 ` [RFC PATCH v4 2/4] fs: add AT_LINK_REPLACE flag for linkat() which replaces the target Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-28 23:19 ` [RFC PATCH v4 3/4] Btrfs: fix inode reference count leak in btrfs_link() error path Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-28 23:19 ` [RFC PATCH v4 4/4] Btrfs: add support for linkat() AT_REPLACE Omar Sandoval 2020-01-29 8:58 ` Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH xfstests] generic: add smoke test for AT_LINK_REPLACE Omar Sandoval [not found] ` <cover.1580251857.git.osandov-b10kYP2dOMg@public.gmane.org> 2020-01-29 8:58 ` Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH man-pages] link.2: Document new AT_LINK_REPLACE flag Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH xfsprogs] xfs_io: add support for linkat() AT_LINK_REPLACE Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH v4 0/4] fs: add flag to linkat() for replacing destination Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH v4 1/4] fs: add flags argument to i_op->link() Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH v4 2/4] fs: add AT_LINK_REPLACE flag for linkat() which replaces the target Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH v4 3/4] Btrfs: fix inode reference count leak in btrfs_link() error path Omar Sandoval 2020-01-29 8:58 ` [RFC PATCH v4 4/4] Btrfs: add support for linkat() AT_REPLACE Omar Sandoval 2020-01-31 13:48 ` [RFC PATCH v4 1/4] fs: add flags argument to i_op->link() David Howells 2020-01-31 20:24 ` Omar Sandoval 2020-01-31 20:24 ` Omar Sandoval
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f23621bea2e8d5f919389131b84fa0226b90f502.1580253372.git.osandov@fb.com \ --to=osandov@osandov.com \ --cc=amir73il@gmail.com \ --cc=dhowells@redhat.com \ --cc=fstests@vger.kernel.org \ --cc=kernel-team@fb.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ --cc=xi@cs.washington.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.