All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Harvey <charvey@matrox.com>
To: dri-devel@lists.freedesktop.org
Cc: Mathieu Larouche <mathieu.larouche@matrox.com>
Subject: [PATCH v2 1/4] drm/mgag200: Don't change unrelated registers during modeset
Date: Fri, 12 Apr 2013 16:42:19 -0400	[thread overview]
Message-ID: <f2ce86439bdd650259e1e7e2e0eabccd56a49a66.1368128053.git.charvey@matrox.com> (raw)
In-Reply-To: <cover.1368128053.git.charvey@matrox.com>

Registers in indices below 0x18 are totally unrelated to modesetting,
so don't write 0's, or anything else into them on modeset. Most of
these registers are hardware cursor related, so this existing code
interferes with hardware cursor development.

Signed-off-by: Christopher Harvey <charvey@matrox.com>
Tested-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Mathieu Larouche <mathieu.larouche@matrox.com>
---
 drivers/gpu/drm/mgag200/mgag200_mode.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index f988965..2d9333d 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -829,11 +829,7 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc,
 
 
 	for (i = 0; i < sizeof(dacvalue); i++) {
-		if ((i <= 0x03) ||
-		    (i == 0x07) ||
-		    (i == 0x0b) ||
-		    (i == 0x0f) ||
-		    ((i >= 0x13) && (i <= 0x17)) ||
+		if ((i <= 0x17) ||
 		    (i == 0x1b) ||
 		    (i == 0x1c) ||
 		    ((i >= 0x1f) && (i <= 0x29)) ||
-- 
1.8.1.5

  reply	other threads:[~2013-05-09 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 19:34 [PATCH v2 0/4] *** SUBJECT HERE *** Christopher Harvey
2013-04-12 20:42 ` Christopher Harvey [this message]
2013-04-12 22:24 ` [PATCH v2 2/4] drm/mgag200: Fix writes into MGA1064_PIX_CLK_CTL register Christopher Harvey
2013-05-06 15:56 ` [PATCH v2 3/4] drm/mgag200: Convert counter delays to jiffies Christopher Harvey
2013-05-08 19:10 ` [PATCH v2 4/4] drm/mgag200: Fix framebuffer base address programming Christopher Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2ce86439bdd650259e1e7e2e0eabccd56a49a66.1368128053.git.charvey@matrox.com \
    --to=charvey@matrox.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mathieu.larouche@matrox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.