All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 6/6] drm/connector: update edid_blob_ptr documentation
Date: Fri, 12 Jan 2024 18:49:58 +0200	[thread overview]
Message-ID: <f75ba2470e26a953b430a21ee1d25514eeafc672.1705078136.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1705078136.git.jani.nikula@intel.com>

Accessing the EDID via edid_blob_ptr causes chicken-and-egg
problems. Keep edid_blob_ptr as the userspace interface that should be
accessed via dedicated functions.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 include/drm/drm_connector.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index fe88d7fc6b8f..58ee9adf9091 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -1636,8 +1636,12 @@ struct drm_connector {
 
 	/**
 	 * @edid_blob_ptr: DRM property containing EDID if present. Protected by
-	 * &drm_mode_config.mutex. This should be updated only by calling
+	 * &drm_mode_config.mutex.
+	 *
+	 * This must be updated only by calling drm_edid_connector_update() or
 	 * drm_connector_update_edid_property().
+	 *
+	 * This must not be used by drivers directly.
 	 */
 	struct drm_property_blob *edid_blob_ptr;
 
-- 
2.39.2


      parent reply	other threads:[~2024-01-12 16:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 16:49 [PATCH 0/6] drm: stop using edid_blob_ptr in drivers Jani Nikula
2024-01-12 16:49 ` [PATCH 1/6] drm/nouveau: convert to using is_hdmi and has_audio from display info Jani Nikula
2024-01-12 16:49   ` Jani Nikula
2024-01-14  5:06   ` Ilia Mirkin
2024-01-15  7:06     ` Jani Nikula
2024-01-15 13:44   ` [PATCH v2] " Jani Nikula
2024-01-15 13:44     ` Jani Nikula
2024-01-12 16:49 ` [PATCH 2/6] drm/radeon: " Jani Nikula
2024-01-12 16:49 ` [PATCH 3/6] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr Jani Nikula
2024-01-12 16:49 ` [PATCH 4/6] drm/amdgpu: remove amdgpu_connector_edid() " Jani Nikula
2024-01-12 16:49 ` [PATCH 5/6] drm/edid: add a helper for EDID sysfs property show Jani Nikula
2024-01-12 16:49 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f75ba2470e26a953b430a21ee1d25514eeafc672.1705078136.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.