From: Nathan Chancellor <nathan@kernel.org>
To: Colin King <colin.king@canonical.com>,
Chas Williams <3chas3@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
clang-built-linux@googlegroups.com
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string
Date: Tue, 20 Jul 2021 10:17:45 -0700 [thread overview]
Message-ID: <fd4f465b-86bd-129d-c6d9-e802b7c4815e@kernel.org> (raw)
In-Reply-To: <20210720124813.59331-1-colin.king@canonical.com>
On 7/20/2021 5:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The character sequence ??) is a trigraph and causes the following
> clang warning:
>
> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
>
> Clean this by replacing it with single ?.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This looks good to me but I am curious how you say this warning in the
first place since the main Makefile disables this unconditionally. Did
you just pass -Wtrigraphs via KCFLAGS or something similar?
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/atm/idt77252.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
> index 9e4bd751db79..81ce81a75fc6 100644
> --- a/drivers/atm/idt77252.c
> +++ b/drivers/atm/idt77252.c
> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card)
> return -1;
> }
> if (!(pci_command & PCI_COMMAND_IO)) {
> - printk("%s: PCI_COMMAND: %04x (???)\n",
> + printk("%s: PCI_COMMAND: %04x (?)\n",
> card->name, pci_command);
> deinit_card(card);
> return (-1);
>
next prev parent reply other threads:[~2021-07-20 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 12:48 [PATCH] atm: idt77252: clean up trigraph warning on ??) string Colin King
2021-07-20 17:17 ` Nathan Chancellor [this message]
2021-07-20 17:21 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd4f465b-86bd-129d-c6d9-e802b7c4815e@kernel.org \
--to=nathan@kernel.org \
--cc=3chas3@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.