All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH 3/3] fsr: remove shadow variable in fsr_setup_attr_fork
Date: Wed, 18 Dec 2019 16:56:20 -0600	[thread overview]
Message-ID: <fd893f4d-f436-b568-8dbf-5522c291952a@sandeen.net> (raw)
In-Reply-To: <291387f3-1517-14c0-f64a-a98164131f89@sandeen.net>

From: Eric Sandeen <sandeen@redhat.com>

There's no need for the extra inner-scope ret variable in this
function, so remove it.  The shadow was harmless though.

Fixes: f31b5e12 ("libfrog: refactor open-coded bulkstat calls")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 77a10a1d..32282126 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -988,7 +988,6 @@ fsr_setup_attr_fork(
 	do {
 		struct xfs_bulkstat	tbstat;
 		char		name[64];
-		int		ret;
 
 		/*
 		 * bulkstat the temp inode to see what the forkoff is.  Use


  parent reply	other threads:[~2019-12-18 22:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 22:53 [PATCH 0/3] xfsprogs: trivial sparse tidyups Eric Sandeen
2019-12-18 22:54 ` [PATCH 1/3] xfsprogs: include headers to fix sparse warnings about statics Eric Sandeen
2019-12-18 23:10   ` Darrick J. Wong
2019-12-18 22:55 ` [PATCH 2/3] xfsprogs: make a couple of structures static Eric Sandeen
2019-12-18 23:09   ` Darrick J. Wong
2019-12-18 22:56 ` Eric Sandeen [this message]
2019-12-18 23:08   ` [PATCH 3/3] fsr: remove shadow variable in fsr_setup_attr_fork Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd893f4d-f436-b568-8dbf-5522c291952a@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.