All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 08/11] iwlwifi: mvm: don't transmit on unallocated queue
Date: Sat, 25 Apr 2020 13:04:56 +0300	[thread overview]
Message-ID: <iwlwifi.20200425130140.dcf1801f25ef.I6d71e13ea042765800f2ee41401b8eb282527c34@changeid> (raw)
In-Reply-To: <20200425100459.2778317-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

We can currently end up transmitting on an unallocated queue, if
the allocation fails. Stop doing that, by simply not transmitting.
We don't have any better strategy here, unfortunately, but the
previous commits make that much less likely.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 3e16bd4190ff..bff520087ed7 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -1395,7 +1395,17 @@ void iwl_mvm_add_new_dqa_stream_wk(struct work_struct *wk)
 		if (tid == IEEE80211_NUM_TIDS)
 			tid = IWL_MAX_TID_COUNT;
 
-		iwl_mvm_sta_alloc_queue(mvm, txq->sta, txq->ac, tid);
+		/*
+		 * We can't really do much here, but if this fails we can't
+		 * transmit anyway - so just don't transmit the frame etc.
+		 * and let them back up ... we've tried our best to allocate
+		 * a queue in the function itself.
+		 */
+		if (iwl_mvm_sta_alloc_queue(mvm, txq->sta, txq->ac, tid)) {
+			list_del_init(&mvmtxq->list);
+			continue;
+		}
+
 		list_del_init(&mvmtxq->list);
 		local_bh_disable();
 		iwl_mvm_mac_itxq_xmit(mvm->hw, txq);
-- 
2.26.2


  parent reply	other threads:[~2020-04-25 10:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 10:04 [PATCH 00/11] iwlwifi: updates intended for v5.8 2020-04-25 Luca Coelho
2020-04-25 10:04 ` [PATCH 01/11] iwlwifi: pcie: allocate much smaller byte-count table Luca Coelho
2020-04-25 10:04 ` [PATCH 02/11] iwlwifi: mvm: attempt to allocate smaller queues Luca Coelho
2020-04-25 10:04 ` [PATCH 03/11] iwlwifi: dbg: mark a variable __maybe_unused Luca Coelho
2020-04-25 10:04 ` [PATCH 04/11] iwlwifi: pcie: remove some dead code Luca Coelho
2020-04-25 10:04 ` [PATCH 05/11] iwlwifi: pcie: gen2: use DMA pool for byte-count tables Luca Coelho
2020-04-25 10:04 ` [PATCH 06/11] iwlwifi: use longer queues for 256-BA Luca Coelho
2020-04-25 10:04 ` [PATCH 07/11] iwlwifi: tx: enable A-MSDU in low latency mode Luca Coelho
2020-04-25 10:04 ` Luca Coelho [this message]
2020-04-25 10:04 ` [PATCH 09/11] iwlwifi: remove outdated copyright print/module statement Luca Coelho
2020-04-25 10:04 ` [PATCH 10/11] iwlwifi: pcie: skip fragmented receive buffers Luca Coelho
2020-04-25 10:04 ` [PATCH 11/11] iwlwifi: dbg_ini: differentiate ax210 hw with same hw type Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20200425130140.dcf1801f25ef.I6d71e13ea042765800f2ee41401b8eb282527c34@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.