All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 08/12] iwlwifi: dbg: remove no filter condition
Date: Wed, 30 Sep 2020 16:31:19 +0300	[thread overview]
Message-ID: <iwlwifi.20200930161256.6a0aae2c0507.I7bd72968279d586af420472707d53106b35efc08@changeid> (raw)
In-Reply-To: <20200930133123.924256-1-luca@coelho.fi>

From: Mordechay Goodstein <mordechay.goodstein@intel.com>

Currently if group-id and command-id values are zero we
trigger and collect every RX frame,
this is not the right behavior and zero value
should be handled like any other filter.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Fixes: 3ed34fbf9d3b ("iwlwifi: dbg_ini: support FW response/notification region type")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index c44e61aa2aca..9b64a12e489d 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -954,9 +954,8 @@ static bool iwl_dbg_tlv_check_fw_pkt(struct iwl_fw_runtime *fwrt,
 	struct iwl_rx_packet *pkt = tp_data->fw_pkt;
 	struct iwl_cmd_header *wanted_hdr = (void *)&trig_data;
 
-	if (pkt && ((wanted_hdr->cmd == 0 && wanted_hdr->group_id == 0) ||
-		    (pkt->hdr.cmd == wanted_hdr->cmd &&
-		     pkt->hdr.group_id == wanted_hdr->group_id))) {
+	if (pkt && (pkt->hdr.cmd == wanted_hdr->cmd &&
+		    pkt->hdr.group_id == wanted_hdr->group_id)) {
 		struct iwl_rx_packet *fw_pkt =
 			kmemdup(pkt,
 				sizeof(*pkt) + iwl_rx_packet_payload_len(pkt),
-- 
2.28.0


  parent reply	other threads:[~2020-09-30 13:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 13:31 [PATCH 00/12] iwlwifi: updates intended for v5.10 2020-09-30 Luca Coelho
2020-09-30 13:31 ` [PATCH 01/12] iwlwifi: mvm: Add FTM initiator RTT smoothing logic Luca Coelho
2020-10-01 19:01   ` Luca Coelho
2020-09-30 13:31 ` [PATCH 02/12] iwlwifi: mvm: location: set the HLTK when PASN station is added Luca Coelho
2020-09-30 13:31 ` [PATCH 03/12] iwlwifi: mvm: responder: allow to set only the HLTK for an associated station Luca Coelho
2020-09-30 13:31 ` [PATCH 04/12] iwlwifi: mvm: initiator: add option for adding a PASN responder Luca Coelho
2020-09-30 13:31 ` [PATCH 05/12] iwlwifi: move all bus-independent TX functions to common code Luca Coelho
2020-09-30 13:31 ` [PATCH 06/12] iwlwifi: mvm: support more GTK rekeying algorithms Luca Coelho
2020-09-30 13:31 ` [PATCH 07/12] iwlwifi: mvm: d3: support GCMP ciphers Luca Coelho
2020-09-30 13:31 ` Luca Coelho [this message]
2020-09-30 13:31 ` [PATCH 09/12] iwlwifi: mvm: add d3 prints Luca Coelho
2020-09-30 13:31 ` [PATCH 10/12] iwlwifi: dbg: run init_cfg function once per driver load Luca Coelho
2020-09-30 13:31 ` [PATCH 11/12] iwlwifi: thermal: support new temperature measurement API Luca Coelho
2020-09-30 13:31 ` [PATCH 12/12] iwlwifi: phy-ctxt: add new API VER 3 for phy context cmd Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20200930161256.6a0aae2c0507.I7bd72968279d586af420472707d53106b35efc08@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.