All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 06/12] iwlwifi: mvm: set enabled in the PPAG command properly
Date: Sun, 31 Jan 2021 20:22:06 +0200	[thread overview]
Message-ID: <iwlwifi.20210131201908.24d7bf754ad5.I0e8abc2b8747508b6118242533d68c856ca6dffb@changeid> (raw)
In-Reply-To: <20210131182212.929755-1-luca@coelho.fi>

From: Luca Coelho <luciano.coelho@intel.com>

When version 2 of the PER_PLATFORM_ANT_GAIN_CMD was implemented, we
started copying the values from the command that we have stored into a
local instance.  But we accidentally forgot to copy the enabled flag,
so in practice PPAG is never really enabled.  Fix this by copying the
flag from our stored data a we should.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Fixes: f2134f66f40e ("iwlwifi: acpi: support ppag table command v2")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index be1cc8653147..9f8751ceb45b 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -999,6 +999,8 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
 		return 0;
 	}
 
+	ppag_table.v1.enabled = mvm->fwrt.ppag_table.v1.enabled;
+
 	cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, PHY_OPS_GROUP,
 					PER_PLATFORM_ANT_GAIN_CMD,
 					IWL_FW_CMD_VER_UNKNOWN);
-- 
2.29.2


  parent reply	other threads:[~2021-01-31 20:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31 18:22 [PATCH 00/12] iwlwifi: updates intended for v5.12 2021-01-31 part 2 Luca Coelho
2021-01-31 18:22 ` [PATCH 01/12] iwlwifi: mvm: add IML/ROM information for other HW families Luca Coelho
2021-02-05  9:59   ` Luca Coelho
2021-01-31 18:22 ` [PATCH 02/12] iwlwifi: mvm: add triggers for MLME events Luca Coelho
2021-01-31 18:22 ` [PATCH 03/12] iwlwifi: fwrt: add suspend/resume time point Luca Coelho
2021-01-31 18:22 ` [PATCH 04/12] iwlwifi: mvm: add tx fail " Luca Coelho
2021-01-31 18:22 ` [PATCH 05/12] iwlwifi: mvm: add debugfs entry to trigger a dump as any time-point Luca Coelho
2021-01-31 18:22 ` Luca Coelho [this message]
2021-01-31 18:22 ` [PATCH 07/12] iwlwifi: mvm: implement approved list for the PPAG feature Luca Coelho
2021-01-31 18:22 ` [PATCH 08/12] iwlwifi: mvm: add HP to the PPAG approved list Luca Coelho
2021-01-31 18:22 ` [PATCH 09/12] iwlwifi: mvm: add Samsung " Luca Coelho
2021-01-31 18:22 ` [PATCH 10/12] iwlwifi: mvm: add Microsoft " Luca Coelho
2021-01-31 18:22 ` [PATCH 11/12] iwlwifi: mvm: add Asus " Luca Coelho
2021-01-31 18:22 ` [PATCH 12/12] iwlwifi: bump FW API to 61 for AX devices Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20210131201908.24d7bf754ad5.I0e8abc2b8747508b6118242533d68c856ca6dffb@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.