All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@kernel.org
Cc: luca@coelho.fi, linux-wireless@vger.kernel.org
Subject: [PATCH 01/11] iwlwifi: fix Bz NMI behaviour
Date: Fri, 10 Dec 2021 09:06:11 +0200	[thread overview]
Message-ID: <iwlwifi.20211210090244.75b6207536e3.I7d170a48a9096e6b7269c3a9f447c326f929b171@changeid> (raw)
In-Reply-To: <20211210070621.236783-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

Contrary to what was stated before, the hardware hasn't changed
the bits here yet. In any case, the new CSR is also directly
(lower 16 bits) connected to UREG_DOORBELL_TO_ISR6, so if it
still changes the changes would be there. Adjust the code and
comments accordingly.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fixes: 6c0795f1a524 ("iwlwifi: implement Bz NMI behaviour")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-csr.h | 5 +++--
 drivers/net/wireless/intel/iwlwifi/iwl-io.c  | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-csr.h b/drivers/net/wireless/intel/iwlwifi/iwl-csr.h
index 21d8249980fa..f90d4662c164 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-csr.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-csr.h
@@ -109,9 +109,10 @@
 #define CSR_IPC_SLEEP_CONTROL_SUSPEND	0x3
 #define CSR_IPC_SLEEP_CONTROL_RESUME	0
 
-/* Doorbell NMI (since Bz) */
+/* Doorbell - since Bz
+ * connected to UREG_DOORBELL_TO_ISR6 (lower 16 bits only)
+ */
 #define CSR_DOORBELL_VECTOR	(CSR_BASE + 0x130)
-#define CSR_DOORBELL_VECTOR_NMI	BIT(1)
 
 /* host chicken bits */
 #define CSR_HOST_CHICKEN	(CSR_BASE + 0x204)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c b/drivers/net/wireless/intel/iwlwifi/iwl-io.c
index 46917b4216b3..253eac4cbf59 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-io.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-io.c
@@ -218,7 +218,7 @@ void iwl_force_nmi(struct iwl_trans *trans)
 				    UREG_DOORBELL_TO_ISR6_NMI_BIT);
 	else
 		iwl_write32(trans, CSR_DOORBELL_VECTOR,
-			    CSR_DOORBELL_VECTOR_NMI);
+			    UREG_DOORBELL_TO_ISR6_NMI_BIT);
 }
 IWL_EXPORT_SYMBOL(iwl_force_nmi);
 
-- 
2.34.1


  reply	other threads:[~2021-12-10  7:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  7:06 [PATCH 00/11] iwlwifi: updates intended for v5.17 2021-12-10 part 1 Luca Coelho
2021-12-10  7:06 ` Luca Coelho [this message]
2021-12-10  7:06 ` [PATCH 02/11] iwlwifi: fw: remove dead error log code Luca Coelho
2021-12-10  7:06 ` [PATCH 03/11] iwlwifi: pcie: add jacket bit to device configuration parsing Luca Coelho
2021-12-10  7:06 ` [PATCH 04/11] iwlwifi: Read the correct addresses when getting the crf id Luca Coelho
2021-12-10  7:06 ` [PATCH 05/11] iwlwifi: mvm: support revision 1 of WTAS table Luca Coelho
2021-12-10  7:06 ` [PATCH 06/11] iwlwifi: mvm: Add list of OEMs allowed to use TAS Luca Coelho
2021-12-10  7:06 ` [PATCH 07/11] iwlwifi: add support for BNJ HW Luca Coelho
2021-12-10  7:06 ` [PATCH 08/11] iwlwifi: mvm: rfi: update rfi table Luca Coelho
2021-12-10  7:06 ` [PATCH 09/11] iwlwifi: rs: add support for TLC config command ver 4 Luca Coelho
2021-12-10  7:06 ` [PATCH 10/11] iwlwifi: recognize missing PNVM data and then log filename Luca Coelho
2021-12-10  7:06 ` [PATCH 11/11] iwlwifi: mvm: Increase the scan timeout guard to 30 seconds Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20211210090244.75b6207536e3.I7d170a48a9096e6b7269c3a9f447c326f929b171@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.