All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@kernel.org
Cc: luca@coelho.fi, linux-wireless@vger.kernel.org
Subject: [PATCH 02/12] iwlwifi: mvm: set protected flag only for NDP ranging
Date: Sun, 19 Dec 2021 13:28:26 +0200	[thread overview]
Message-ID: <iwlwifi.20211219132536.f50ed0e3c6b3.Ibff247ee9d4e6e0a1a2d08a3c8a4bbb37e6829dd@changeid> (raw)
In-Reply-To: <20211219112836.132859-1-luca@coelho.fi>

From: Avraham Stern <avraham.stern@intel.com>

Don't use protected ranging negotiation for FTM ranging as responders
that support only FTM ranging don't expect the FTM request to be
protected.

Signed-off-by: Avraham Stern <avraham.stern@intel.com>
Fixes: 517a5eb9fab2 ("iwlwifi: mvm: when associated with PMF, use protected NDP ranging negotiation")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
index 3e6c13fc74eb..9449d1af3c11 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
@@ -511,7 +511,7 @@ iwl_mvm_ftm_put_target(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
 		rcu_read_lock();
 
 		sta = rcu_dereference(mvm->fw_id_to_mac_id[mvmvif->ap_sta_id]);
-		if (sta->mfp)
+		if (sta->mfp && (peer->ftm.trigger_based || peer->ftm.non_trigger_based))
 			FTM_PUT_FLAG(PMF);
 
 		rcu_read_unlock();
-- 
2.34.1


  parent reply	other threads:[~2021-12-19 11:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-19 11:28 [PATCH 00/12] iwlwifi: updates intended for v5.17 2021-12-19 part 2 Luca Coelho
2021-12-19 11:28 ` [PATCH 01/12] iwlwifi: pcie: add killer devices to the driver Luca Coelho
2021-12-19 11:28 ` Luca Coelho [this message]
2021-12-19 11:28 ` [PATCH 03/12] iwlwifi: mvm: correctly set schedule scan profiles Luca Coelho
2021-12-19 11:28 ` [PATCH 04/12] iwlwifi: mvm: fix rfi get table vendor command handler Luca Coelho
2021-12-19 11:28 ` [PATCH 05/12] iwlwifi: mvm: support Bz TX checksum offload Luca Coelho
2021-12-19 11:28 ` [PATCH 06/12] iwlwifi: return op_mode only in case the failure is from MEI Luca Coelho
2021-12-19 11:28 ` [PATCH 07/12] iwlwifi: mvm: fix AUX ROC removal Luca Coelho
2021-12-19 11:28 ` [PATCH 08/12] iwlwifi: mvm: drop too short packets silently Luca Coelho
2021-12-19 11:28 ` [PATCH 09/12] iwlwifi: mvm: remove card state notification code Luca Coelho
2021-12-19 11:28 ` [PATCH 10/12] iwlwifi: pcie: make sure prph_info is set when treating wakeup IRQ Luca Coelho
2021-12-19 11:28 ` [PATCH 11/12] iwlwifi: fw: fix some scan kernel-doc Luca Coelho
2021-12-19 11:28 ` [PATCH 12/12] iwlwifi: yoyo: fix issue with new DBGI_SRAM region read Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20211219132536.f50ed0e3c6b3.Ibff247ee9d4e6e0a1a2d08a3c8a4bbb37e6829dd@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.