All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@kernel.org
Cc: luca@coelho.fi, linux-wireless@vger.kernel.org
Subject: [PATCH 11/12] iwlwifi: yoyo: remove DBGI_SRAM address reset writing
Date: Sat, 29 Jan 2022 13:16:21 +0200	[thread overview]
Message-ID: <iwlwifi.20220129105618.209f3078bc74.I463530bd2f40daedb39f6d9df987bb7cee209033@changeid> (raw)
In-Reply-To: <20220129111622.678447-1-luca@coelho.fi>

From: Rotem Saado <rotem.saado@intel.com>

Due to preg protection we cannot write to this register
while FW is running (when FW in Halt it is ok).
since we have some cases that we need to dump this
region while FW is running remove this writing from DRV.
FW will do this writing.

Signed-off-by: Rotem Saado <rotem.saado@intel.com>
Fixes: 89639e06d0f3 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/fw/dbg.c   | 2 --
 drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index d3e1c89d9be7..6e090f10b8eb 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -1561,8 +1561,6 @@ iwl_dump_ini_dbgi_sram_iter(struct iwl_fw_runtime *fwrt,
 		return -EBUSY;
 
 	range->range_data_size = reg->dev_addr.size;
-	iwl_write_prph_no_grab(fwrt->trans, DBGI_SRAM_TARGET_ACCESS_CFG,
-			       DBGI_SRAM_TARGET_ACCESS_CFG_RESET_ADDRESS_MSK);
 	for (i = 0; i < (le32_to_cpu(reg->dev_addr.size) / 4); i++) {
 		prph_data = iwl_read_prph_no_grab(fwrt->trans, (i % 2) ?
 					  DBGI_SRAM_TARGET_ACCESS_RDATA_MSB :
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
index 186e22c4e6c4..8d37a7e8fa6e 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
@@ -354,8 +354,6 @@
 #define WFPM_GP2			0xA030B4
 
 /* DBGI SRAM Register details */
-#define DBGI_SRAM_TARGET_ACCESS_CFG			0x00A2E14C
-#define DBGI_SRAM_TARGET_ACCESS_CFG_RESET_ADDRESS_MSK	0x10000
 #define DBGI_SRAM_TARGET_ACCESS_RDATA_LSB		0x00A2E154
 #define DBGI_SRAM_TARGET_ACCESS_RDATA_MSB		0x00A2E158
 #define DBGI_SRAM_FIFO_POINTERS				0x00A2E148
-- 
2.34.1


  parent reply	other threads:[~2022-01-29 11:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29 11:16 [PATCH 00/12] iwlwifi: updates intended for v5.18 2022-01-29 Luca Coelho
2022-01-29 11:16 ` [PATCH 01/12] iwlwifi: dbg: add infra for tracking free buffer size Luca Coelho
2022-01-29 11:16 ` [PATCH 02/12] iwlwifi: yoyo: fix DBGI_SRAM ini dump header Luca Coelho
2022-01-29 11:16 ` [PATCH 03/12] iwlwifi: mvm: only enable HE DCM if we also support TX Luca Coelho
2022-01-29 11:16 ` [PATCH 04/12] iwlwifi: advertise support for HE - DCM BPSK RX/TX Luca Coelho
2022-01-29 11:16 ` [PATCH 05/12] iwlwifi: mvm: don't iterate unadded vifs when handling FW SMPS req Luca Coelho
2022-01-29 11:16 ` [PATCH 06/12] iwlwifi: mvm: align locking in D3 test debugfs Luca Coelho
2022-01-29 11:16 ` [PATCH 07/12] iwlwifi: pcie: add support for MS devices Luca Coelho
2022-01-29 11:16 ` [PATCH 08/12] iwlwifi: yoyo: fix DBGC allocation flow Luca Coelho
2022-01-29 11:16 ` [PATCH 09/12] iwlwifi: yoyo: add IMR DRAM dump support Luca Coelho
2022-01-29 11:16 ` [PATCH 10/12] iwlwifi: mvm: support v3 of station HE context command Luca Coelho
2022-01-29 11:16 ` Luca Coelho [this message]
2022-01-29 11:16 ` [PATCH 12/12] iwlwifi: mvm: add support for CT-KILL notification version 2 Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20220129105618.209f3078bc74.I463530bd2f40daedb39f6d9df987bb7cee209033@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.