All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Sundin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Stefan Sundin <git@stefansundin.com>,
	Stefan Sundin <git@stefansundin.com>
Subject: [PATCH] Makefile: suppress macOS deprecation warning
Date: Sat, 19 Nov 2022 20:06:47 +0000	[thread overview]
Message-ID: <pull.1422.git.1668888407433.gitgitgadget@gmail.com> (raw)

From: Stefan Sundin <git@stefansundin.com>

Compiling git on macOS 13 emits the following deprecation warning:

        CC compat/fsmonitor/fsm-listen-darwin.o
    compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
            FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
            ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
    FSEventStreamScheduleWithRunLoop(
    ^
    1 warning generated.

Setting a minimum macOS version will suppress this deprecation warning.
Using a version lower than 10.13 will cause other warning messages to
be emitted.

Signed-off-by: Stefan Sundin <git@stefansundin.com>
---
    Makefile: suppress macOS deprecation warning

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1422%2Fstefansundin%2Fmacosx-version-min-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1422/stefansundin/macosx-version-min-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1422

 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 4927379184c..8a729efd2d1 100644
--- a/Makefile
+++ b/Makefile
@@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T))
 endif
 
 ifeq ($(uname_S),Darwin)
+	BASIC_CFLAGS += -mmacosx-version-min=10.13
 	ifndef NO_FINK
 		ifeq ($(shell test -d /sw/lib && echo y),y)
 			BASIC_CFLAGS += -I/sw/include

base-commit: eea7033409a0ed713c78437fc76486983d211e25
-- 
gitgitgadget

             reply	other threads:[~2022-11-19 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 20:06 Stefan Sundin via GitGitGadget [this message]
2022-11-20  1:48 ` [PATCH] Makefile: suppress macOS deprecation warning Bagas Sanjaya
2022-11-20  2:14   ` Stefan Sundin
2022-11-20 12:29     ` Bagas Sanjaya
2022-12-01 18:53       ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1422.git.1668888407433.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@stefansundin.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.