From: "謝致邦 (XIE Zhibang) via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "謝致邦 (XIE Zhibang)" <Yeking@Red54.com>,
"谢致邦 (XIE Zhibang)" <Yeking@Red54.com>
Subject: [PATCH] doc: correct the 50 characters soft limit (+)
Date: Sun, 08 Oct 2023 14:10:16 +0000 [thread overview]
Message-ID: <pull.1585.git.git.1696774217058.gitgitgadget@gmail.com> (raw)
From: =?UTF-8?q?=E8=B0=A2=E8=87=B4=E9=82=A6=20=28XIE=20Zhibang=29?=
<Yeking@Red54.com>
The soft limit of the first line of the commit message should be
"no more than 50 characters" or "50 characters or less", but not
"less than 50 character".
This is an addition to commit c2c349a15c0430a2ef9f858d69d095a00693379c
("doc: correct the 50 characters soft limit").
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
doc: correct the 50 characters soft limit (+)
The soft limit of the first line of the commit message should be "no
more than 50 characters" or "50 characters or less", but not "less than
50 character".
This is an addition to commit c2c349a15c0430a2ef9f858d69d095a00693379c
("doc: correct the 50 characters soft limit").
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1585%2FRed54%2Fdoc-patch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1585/Red54/doc-patch-v1
Pull-Request: https://github.com/git/git/pull/1585
Documentation/gittutorial.txt | 8 ++++----
Documentation/user-manual.txt | 2 +-
po/README.md | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/gittutorial.txt b/Documentation/gittutorial.txt
index c7cadd8aaf1..47594087880 100644
--- a/Documentation/gittutorial.txt
+++ b/Documentation/gittutorial.txt
@@ -137,10 +137,10 @@ which will automatically notice any modified (but not new) files, add
them to the index, and commit, all in one step.
A note on commit messages: Though not required, it's a good idea to
-begin the commit message with a single short (less than 50 character)
-line summarizing the change, followed by a blank line and then a more
-thorough description. The text up to the first blank line in a commit
-message is treated as the commit title, and that title is used
+begin the commit message with a single short (no more than 50
+characters) line summarizing the change, followed by a blank line and
+then a more thorough description. The text up to the first blank line in
+a commit message is treated as the commit title, and that title is used
throughout Git. For example, linkgit:git-format-patch[1] turns a
commit into email, and it uses the title on the Subject line and the
rest of the commit in the body.
diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt
index 4281396093d..d8dbe6b56d4 100644
--- a/Documentation/user-manual.txt
+++ b/Documentation/user-manual.txt
@@ -1122,7 +1122,7 @@ choosing "Stage Hunk For Commit").
=== Creating good commit messages
Though not required, it's a good idea to begin the commit message
-with a single short (less than 50 character) line summarizing the
+with a single short (no more than 50 characters) line summarizing the
change, followed by a blank line and then a more thorough
description. The text up to the first blank line in a commit
message is treated as the commit title, and that title is used
diff --git a/po/README.md b/po/README.md
index 3e4f897d935..ec08aa24add 100644
--- a/po/README.md
+++ b/po/README.md
@@ -412,7 +412,7 @@ There are some conventions that l10n contributors must follow:
- Do not use non-ASCII characters in the subject of a commit.
- The length of commit subject (first line of the commit log) should
- be less than 50 characters, and the length of other lines of the
+ be no more than 50 characters, and the length of other lines of the
commit log should be no more than 72 characters.
- Add "Signed-off-by" trailer to your commit log, like other commits
base-commit: 3a06386e314565108ad56a9bdb8f7b80ac52fb69
--
gitgitgadget
next reply other threads:[~2023-10-08 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 14:10 謝致邦 (XIE Zhibang) via GitGitGadget [this message]
2023-10-08 14:37 ` [PATCH] doc: correct the 50 characters soft limit (+) Kristoffer Haugsbakk
2023-10-08 15:19 ` [PATCH v2] " 謝致邦 (XIE Zhibang) via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1585.git.git.1696774217058.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Yeking@Red54.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.