Re: PM issue with Intel SST Atom driver

[Takashi Iwai <tiwai@suse.de>]

On Mon, 24 Apr 2017 11:12:14 +0200,
Vinod Koul wrote:
> 
> On Mon, Apr 24, 2017 at 11:00:45AM +0200, Takashi Iwai wrote:
>  
> > Removing ignore_suspend makes the PM succeeds.  But it hits some other
> > ugly kernel bugs.
> 
> Okay have you marked .nonatomic = true for the machine DAIs?

Ah that's it.  The patch below seems fixing the PM and the nonatomic
problems.  I'm not sure about the nonatomic flag for the compress
stream, though.

Also I fiddled only with FE.  Do we need the same flags for BE?  The
others don't look setting like that, so I left so.


thanks,

Takashi

---
 sound/soc/intel/boards/bytcr_rt5640.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -646,7 +646,7 @@ static struct snd_soc_dai_link byt_rt564
 		.codec_dai_name = "snd-soc-dummy-dai",
 		.codec_name = "snd-soc-dummy",
 		.platform_name = "sst-mfld-platform",
-		.ignore_suspend = 1,
+		.nonatomic = true,
 		.dynamic = 1,
 		.dpcm_playback = 1,
 		.dpcm_capture = 1,
@@ -659,7 +659,6 @@ static struct snd_soc_dai_link byt_rt564
 		.codec_dai_name = "snd-soc-dummy-dai",
 		.codec_name = "snd-soc-dummy",
 		.platform_name = "sst-mfld-platform",
-		.ignore_suspend = 1,
 		.nonatomic = true,
 		.dynamic = 1,
 		.dpcm_playback = 1,
@@ -672,6 +671,7 @@ static struct snd_soc_dai_link byt_rt564
 		.codec_dai_name = "snd-soc-dummy-dai",
 		.codec_name = "snd-soc-dummy",
 		.platform_name = "sst-mfld-platform",
+		.nonatomic = true,
 	},
 		/* back ends */
 	{