From: Takashi Iwai <tiwai@suse.de>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-pm@vger.kernel.org, Mark Scott <markcscott@talktalk.net>,
Benoit Goby <benoit@android.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: commit 70fea60d888d caused s2ram regression with WD disk
Date: Mon, 15 Jun 2015 13:31:04 +0200 [thread overview]
Message-ID: <s5hoakhgqdj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150615025536.GA26473@aaronlu.sh.intel.com>
At Mon, 15 Jun 2015 10:55:36 +0800,
Aaron Lu wrote:
>
> Hi,
>
> As explained by Takashi:
> "
> So this looks like the cause. The recent kernel has a watchdog for
> async resume workers, and if it expires, it panics. This explains why
> 3.12 worked; the watchdog was introduced since 3.13.
>
> The timeout length is unfortunately fixed in Kconfig, set to 12 as
> default. And this seems too short. We should extend this to at least a
> minute, I suppose. Also, it'd be better to be dynamically
> configuratble.
> "
> https://bugzilla.opensuse.org/show_bug.cgi?id=934397#c5
>
> The upstream bug page is here:
> https://bugzilla.kernel.org/show_bug.cgi?id=91921
> Since Benoit isn't registered there, I write the email for discussion.
Thanks Aaron for starting a thread.
Below is a patch to make the default value a bit safer.
I can submit another patch to add a boot option to change the timeout
value, too, if anyone thinks it's worth. Just let me know.
thanks,
Takashi
-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] PM: Increase default DPM watchdog timeout to 60
Many harddisks (mostly WD ones) have firmware problems and take too
long, more than 10 seconds, to resume from suspend. And this often
exceeds the default DPM watchdog timeout (12 seconds), resulting in a
kernel panic out of sudden.
Since most distros just take the default as is, we should give a bit
more safer value. This patch increases the default value from 12
seconds to one minute, which has been confirmed to be long enough for
such problematic disks.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91921
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
kernel/power/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 7e01f78f0417..9e302315e33d 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -187,7 +187,7 @@ config DPM_WATCHDOG
config DPM_WATCHDOG_TIMEOUT
int "Watchdog timeout in seconds"
range 1 120
- default 12
+ default 60
depends on DPM_WATCHDOG
config PM_TRACE
--
2.4.3
next prev parent reply other threads:[~2015-06-15 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 2:55 commit 70fea60d888d caused s2ram regression with WD disk Aaron Lu
2015-06-15 11:31 ` Takashi Iwai [this message]
2015-06-15 23:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hoakhgqdj.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=aaron.lu@intel.com \
--cc=benoit@android.com \
--cc=linux-pm@vger.kernel.org \
--cc=markcscott@talktalk.net \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.