From: tip-bot for Jan Beulich <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: boris.ostrovsky@oracle.com, jbeulich@suse.com, bp@alien8.de, david.vrabel@citrix.com, torvalds@linux-foundation.org, brgerst@gmail.com, hpa@zytor.com, akpm@linux-foundation.org, JGross@suse.com, peterz@infradead.org, JBeulich@suse.com, dvlasenk@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, vkuznets@redhat.com, toshi.kani@hp.com, luto@amacapital.net, xen-devel@lists.xenproject.org, mcgrof@suse.com Subject: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests Date: Fri, 22 Apr 2016 02:47:53 -0700 [thread overview] Message-ID: <tip-103f6112f253017d7062cd74d17f4a514ed4485c@git.kernel.org> (raw) In-Reply-To: <57188ED802000078000E431C@prv-mh.provo.novell.com> Commit-ID: 103f6112f253017d7062cd74d17f4a514ed4485c Gitweb: http://git.kernel.org/tip/103f6112f253017d7062cd74d17f4a514ed4485c Author: Jan Beulich <JBeulich@suse.com> AuthorDate: Thu, 21 Apr 2016 00:27:04 -0600 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 22 Apr 2016 10:05:00 +0200 x86/mm/xen: Suppress hugetlbfs in PV guests Huge pages are not normally available to PV guests. Not suppressing hugetlbfs use results in an endless loop of page faults when user mode code tries to access a hugetlbfs mapped area (since the hypervisor denies such PTEs to be created, but error indications can't be propagated out of xen_set_pte_at(), just like for various of its siblings), and - once killed in an oops like this: kernel BUG at .../fs/hugetlbfs/inode.c:428! invalid opcode: 0000 [#1] SMP ... RIP: e030:[<ffffffff811c333b>] [<ffffffff811c333b>] remove_inode_hugepages+0x25b/0x320 ... Call Trace: [<ffffffff811c3415>] hugetlbfs_evict_inode+0x15/0x40 [<ffffffff81167b3d>] evict+0xbd/0x1b0 [<ffffffff8116514a>] __dentry_kill+0x19a/0x1f0 [<ffffffff81165b0e>] dput+0x1fe/0x220 [<ffffffff81150535>] __fput+0x155/0x200 [<ffffffff81079fc0>] task_work_run+0x60/0xa0 [<ffffffff81063510>] do_exit+0x160/0x400 [<ffffffff810637eb>] do_group_exit+0x3b/0xa0 [<ffffffff8106e8bd>] get_signal+0x1ed/0x470 [<ffffffff8100f854>] do_signal+0x14/0x110 [<ffffffff810030e9>] prepare_exit_to_usermode+0xe9/0xf0 [<ffffffff814178a5>] retint_user+0x8/0x13 This is CVE-2016-3961 / XSA-174. Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: Jan Beulich <jbeulich@suse.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Juergen Gross <JGross@suse.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Luis R. Rodriguez <mcgrof@suse.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Toshi Kani <toshi.kani@hp.com> Cc: stable@vger.kernel.org Cc: xen-devel <xen-devel@lists.xenproject.org> Link: http://lkml.kernel.org/r/57188ED802000078000E431C@prv-mh.provo.novell.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/include/asm/hugetlb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h index f8a29d2..e6a8613 100644 --- a/arch/x86/include/asm/hugetlb.h +++ b/arch/x86/include/asm/hugetlb.h @@ -4,6 +4,7 @@ #include <asm/page.h> #include <asm-generic/hugetlb.h> +#define hugepages_supported() cpu_has_pse static inline int is_hugepage_only_range(struct mm_struct *mm, unsigned long addr,
WARNING: multiple messages have this Message-ID (diff)
From: tip-bot for Jan Beulich <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: JGross@suse.com, dvlasenk@redhat.com, xen-devel@lists.xenproject.org, tglx@linutronix.de, peterz@infradead.org, brgerst@gmail.com, mcgrof@suse.com, linux-kernel@vger.kernel.org, mingo@kernel.org, vkuznets@redhat.com, bp@alien8.de, david.vrabel@citrix.com, JBeulich@suse.com, hpa@zytor.com, toshi.kani@hp.com, boris.ostrovsky@oracle.com, luto@amacapital.net, torvalds@linux-foundation.org, akpm@linux-foundation.org Subject: [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests Date: Fri, 22 Apr 2016 02:47:53 -0700 [thread overview] Message-ID: <tip-103f6112f253017d7062cd74d17f4a514ed4485c@git.kernel.org> (raw) In-Reply-To: <57188ED802000078000E431C@prv-mh.provo.novell.com> Commit-ID: 103f6112f253017d7062cd74d17f4a514ed4485c Gitweb: http://git.kernel.org/tip/103f6112f253017d7062cd74d17f4a514ed4485c Author: Jan Beulich <JBeulich@suse.com> AuthorDate: Thu, 21 Apr 2016 00:27:04 -0600 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 22 Apr 2016 10:05:00 +0200 x86/mm/xen: Suppress hugetlbfs in PV guests Huge pages are not normally available to PV guests. Not suppressing hugetlbfs use results in an endless loop of page faults when user mode code tries to access a hugetlbfs mapped area (since the hypervisor denies such PTEs to be created, but error indications can't be propagated out of xen_set_pte_at(), just like for various of its siblings), and - once killed in an oops like this: kernel BUG at .../fs/hugetlbfs/inode.c:428! invalid opcode: 0000 [#1] SMP ... RIP: e030:[<ffffffff811c333b>] [<ffffffff811c333b>] remove_inode_hugepages+0x25b/0x320 ... Call Trace: [<ffffffff811c3415>] hugetlbfs_evict_inode+0x15/0x40 [<ffffffff81167b3d>] evict+0xbd/0x1b0 [<ffffffff8116514a>] __dentry_kill+0x19a/0x1f0 [<ffffffff81165b0e>] dput+0x1fe/0x220 [<ffffffff81150535>] __fput+0x155/0x200 [<ffffffff81079fc0>] task_work_run+0x60/0xa0 [<ffffffff81063510>] do_exit+0x160/0x400 [<ffffffff810637eb>] do_group_exit+0x3b/0xa0 [<ffffffff8106e8bd>] get_signal+0x1ed/0x470 [<ffffffff8100f854>] do_signal+0x14/0x110 [<ffffffff810030e9>] prepare_exit_to_usermode+0xe9/0xf0 [<ffffffff814178a5>] retint_user+0x8/0x13 This is CVE-2016-3961 / XSA-174. Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: Jan Beulich <jbeulich@suse.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Juergen Gross <JGross@suse.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Luis R. Rodriguez <mcgrof@suse.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Toshi Kani <toshi.kani@hp.com> Cc: stable@vger.kernel.org Cc: xen-devel <xen-devel@lists.xenproject.org> Link: http://lkml.kernel.org/r/57188ED802000078000E431C@prv-mh.provo.novell.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/include/asm/hugetlb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h index f8a29d2..e6a8613 100644 --- a/arch/x86/include/asm/hugetlb.h +++ b/arch/x86/include/asm/hugetlb.h @@ -4,6 +4,7 @@ #include <asm/page.h> #include <asm-generic/hugetlb.h> +#define hugepages_supported() cpu_has_pse static inline int is_hugepage_only_range(struct mm_struct *mm, unsigned long addr, _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-22 9:51 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-21 6:27 [PATCH] x86/xen: suppress hugetlbfs in PV guests Jan Beulich 2016-04-22 9:47 ` tip-bot for Jan Beulich [this message] 2016-04-22 9:47 ` [tip:x86/asm] x86/mm/xen: Suppress " tip-bot for Jan Beulich 2016-04-22 18:03 ` H. Peter Anvin 2016-04-22 18:03 ` H. Peter Anvin 2016-04-22 18:16 ` Borislav Petkov 2016-04-22 18:16 ` Borislav Petkov 2016-04-25 7:37 ` Jan Beulich 2016-04-25 7:52 ` Thomas Gleixner 2016-04-25 7:52 ` Thomas Gleixner 2016-04-25 12:39 ` [Xen-devel] " David Vrabel 2016-04-25 12:39 ` David Vrabel 2016-04-25 7:37 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-103f6112f253017d7062cd74d17f4a514ed4485c@git.kernel.org \ --to=tipbot@zytor.com \ --cc=JGross@suse.com \ --cc=akpm@linux-foundation.org \ --cc=boris.ostrovsky@oracle.com \ --cc=bp@alien8.de \ --cc=brgerst@gmail.com \ --cc=david.vrabel@citrix.com \ --cc=dvlasenk@redhat.com \ --cc=hpa@zytor.com \ --cc=jbeulich@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=mcgrof@suse.com \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=toshi.kani@hp.com \ --cc=vkuznets@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.