RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: David Young <dyoung-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: "radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org"
	<radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org>
Subject: Re: TSFT
Date: Sat, 17 Nov 2012 09:45:50 +0100
Message-ID: <1353141950.9543.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20121117064848.GO21779-Gq8g4XVd89tWk0Htik3J/w@public.gmane.org>

On Sat, 2012-11-17 at 00:48 -0600, David Young wrote:
> On Fri, Nov 16, 2012 at 10:26:31PM -0800, Simon Barber wrote:
> > This is the current definition of TSFT:
> > 
> > "Value in microseconds of the MAC's 64-bit 802.11 Time
> > Synchronization Function timer when the first bit of the MPDU
> > arrived at the MAC. For received frames only."
> > 
> > My experience with TSFT is with Atheros cards, which record the
> > timestamp at the end of the frame, not the start.
> 
> Interesting.  Is it consistent across the whole Atheros product line?

Pretty much.

> > Furthermore for DSSS/CCK the definition above is reasonable, but for
> > OFDM and HT (802.11n) the SIGNAL field (part of the PLCP header, not
> > part of the MPDU) is part of the first data symbol. It would be much
> > clearer to change the definition to state that the timestamp is at
> > the start of this first SIGNAL/data symbol. Any objections to doing
> > this, or preference to change the reference point to a different
> > part of the frame?
> > 
> > In my wireshark patch I've added options to interpret TSFT as the
> > start of end of the frame.
> 
> I think we need 1) a methodology for an author to identify their
> device's reference point so that they can calibrate their driver to the
> standard and/or 2) a radiotap datum that identifies the reference point
> in use or 3) something entirely different.

FWIW, for the Atheros drivers we *just* added (1) to the Linux kernel,
but for radiotap output we calculate the difference to the start of the
frame, see here:

http://git.kernel.org/?p=linux/kernel/git/jberg/mac80211-next.git;a=commit;h=f4bda337bbb6e245e2a07f344990adeb6a70ff35

(the patches for the drivers are separate, but simply change the _START
flag to _END)

I have no objections to (also) allowing this information to be in
radiotap though, but I'm not sure we want to? Our (Intel's) device for
example has the "on air rise" timestamp which is different again, so we
could potentially end up with at least three different reference points?
OTOH, I don't see more than these three making sense at all...

johannes

  parent reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17  6:26 TSFT Simon Barber
     [not found] ` <50A72E17.6070207-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-11-17  6:48   ` TSFT David Young
     [not found]     ` <20121117064848.GO21779-Gq8g4XVd89tWk0Htik3J/w@public.gmane.org>
2012-11-17  8:45       ` Johannes Berg [this message]
     [not found]         ` <1353141950.9543.3.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-11-17 17:46           ` TSFT David Young
     [not found]             ` <20121117174600.GQ21779-Gq8g4XVd89tWk0Htik3J/w@public.gmane.org>
2012-11-17 18:43               ` TSFT Johannes Berg
2012-11-17 18:56               ` TSFT Guy Harris
2012-11-17 23:26   ` TSFT Thomas Pedersen
2012-11-18  7:20     ` TSFT Simon Barber
     [not found]       ` <50A88C3D.5030809-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-11-18 11:07         ` TSFT Johannes Berg
     [not found]           ` <1353236845.9649.6.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-11-20 22:43             ` TSFT Simon Barber
     [not found]               ` <50AC0791.3040005-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-11-21 10:42                 ` TSFT Johannes Berg

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353141950.9543.3.camel@jlt4.sipsolutions.net \
    --to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
    --cc=dyoung-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    --cc=radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git