From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: TSFT Date: Sun, 18 Nov 2012 12:07:25 +0100 Message-ID: <1353236845.9649.6.camel@jlt4.sipsolutions.net> References: <50A72E17.6070207@superduper.net> <50A88C3D.5030809@superduper.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50A88C3D.5030809-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org> Sender: radiotap-owner-sUITvd46vNxg9hUCZPvPmw@public.gmane.org To: Simon Barber Cc: Thomas Pedersen , "radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org" List-Id: radiotap@radiotap.org On Sat, 2012-11-17 at 23:20 -0800, Simon Barber wrote: > Unfortunately this patch does not do a very accurate calculation, so it > makes the problem worse. It simply multiplies rate by the number of > bits to get a time. This does not take into account the limited > accuracy in rate (11n has fractional rates), nor does it consider the > rounding into blocks caused by FEC, or symbols. As a result the data is > made worse by the current code. Either the code should do an accurate > fix, or it should record the raw value and let the end user correct it > properly. If we can, I'd say we should fix the calculations. The question is how we define it when the first bit of the MPDU can be fractional in a symbol? johannes