RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Guy Harris <guy-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
To: Richard Sharpe
	<realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: Re: Correct radiotap header for 802.11ad
Date: Sat, 22 Aug 2015 13:59:38 -0700
Message-ID: <38F46E1D-1C4A-48DC-A906-9522006E8474@alum.mit.edu> (raw)
In-Reply-To: <CACyXjPzq-ePB1ux6wi_Rv3onPKXomcJcm15XJwA51u0E4W2txw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


On Aug 22, 2015, at 12:41 PM, Richard Sharpe <realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> I have some 802.11ad captures because of some fixes to the Wireshark
> 802.11 dissector I am looking at doing.
> 
> One thing I notice is that the radiotap header contains both a Channel field
> and an MCS field.

That is to be expected for 11n packets.

> The Present flags say that Flags are present, Channel is present and
> HT Information is present.

By "HT Information" do you mean "the MCS field"?

The "MCS" field should, perhaps, have been called the "HT" field, as it's information for the HT (11n) PHY, just as the VHT field is information for the VHT (11ac) PHY.

> The channel frequency is 60480MHz which seems to be reasonable.
> 
> The MCS field says that the MCS index is present and that index is 0.
> 
> It seems to me that this last field is perhaps incorrect, because the
> radiotap information dissector claims that the PHY type is 802.11n,
> and that seems to come about because the radiotap header use the MCS
> index info to claim that the PHY type was 802.11n.

Well, to be fair, that's the Wireshark code doing that, under the non-unreasonable assumption that if there's an MCS field it's an HT frame, just as it assumes that if there's a VHT field it's a VHT frame.

From the *radiotap* point of view, I would say that the last field is incorrect because the page for the MCS field on the radiotap site says:

	The mcs field indicates the MCS rate index as in IEEE_802.11n-2009.

which, if we update it to say "as in Clause 20 of IEEE 802.11-2012", means it has values from 0 to 76, with modulations different from the ones in 11ad's Clause 21, i.e. the radiotap MCS field is *not* appropriate for 11ad.

> Should I be letting the capture hardware vendor know that they are
> generating the wrong info?

I'm not even remotely an expert on 802.11 at the PHY level, but I suspect that what we really want for radiotap is a "DMG" field, containing 11ad-specific information.  It would include its own mcs field, giving the MCS values from Clause 21, and perhaps other information, such as a flag to indicate whether "Static Tone Pairing" or "Dynamic Tone Pairing" was used.  (Again, I leave it up to people more familiar with 802.11ad to decide what information would be useful.)

Would the existing A-MPDU field suffice for MPDUs inside an 11ad A-MPDU?

  parent reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 19:41 Richard Sharpe
     [not found] ` <CACyXjPzq-ePB1ux6wi_Rv3onPKXomcJcm15XJwA51u0E4W2txw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-22 20:59   ` Guy Harris [this message]
     [not found]     ` <38F46E1D-1C4A-48DC-A906-9522006E8474-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-08-22 22:06       ` Richard Sharpe
     [not found]         ` <CACyXjPx81fh_jeQSUjE-_w8NQ_Jr-ajmnVWSopfzcLPOWoGmGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-22 22:24           ` Guy Harris
2015-08-22 23:34       ` Guy Harris
     [not found]         ` <1606812C-649C-4C06-ABE0-AE2F4474BCD0-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-08-24  7:40           ` Johannes Berg
     [not found]             ` <1440402013.3735.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-08-24 16:21               ` Richard Sharpe
     [not found]                 ` <CACyXjPwSZPV+U_=zQpDBpeBnhMntzEFhyJnBOw3-N8qPfyHc1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-24 16:28                   ` Johannes Berg
2015-08-26 22:59                   ` Simon Barber
     [not found]                     ` <55DE44EB.6080603-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2015-08-27  1:17                       ` Guy Harris
     [not found]                         ` <126B842D-05EA-4510-BC9B-DB1A4AABEC12-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-09-10 18:25                           ` Guy Harris
     [not found]                             ` <1135A126-6A5A-4C84-A52D-13C0387609CC-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-09-17 16:37                               ` Johannes Berg
2019-12-10 23:51                                 ` Guy Harris
2019-12-11  8:32                                   ` Johannes Berg
2019-12-11  9:39                                     ` Krishna Chaitanya
2019-12-11 12:57                                       ` Johannes Berg
2019-12-11 13:20                                         ` Krishna Chaitanya
2019-12-20 21:56                                     ` Guy Harris
2015-09-17 16:32                       ` Johannes Berg
2015-08-26 22:56       ` Simon Barber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38F46E1D-1C4A-48DC-A906-9522006E8474@alum.mit.edu \
    --to=guy-frubxkncsvf2fbvcvol8/a@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    --cc=realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org radiotap@archiver.kernel.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git