Re: [RFA v3] TLV fields for radiotap

[Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Some code to back this up :-)

Here's a preliminary wireshark patch:
https://p.sipsolutions.net/0ad94ec27dbe26ad.txt

It works, but it's debatable if we really should add everything inside
the TLV. I guess we sort of should, but it makes looking for things a
bit tricky, so I guess at least we should resolve the name of the field
in the item_tree.

I should probably also rename item -> field here and in the proposed
spec text.

Here's a very rudimentary - and sort of wrong - patch for hwsim to
generate a sample capture file.

https://p.sipsolutions.net/83c6ff1e85e3e678.txt

It's wrong because it shouldn't put the channel field into a TLV, but
that's good for demonstrating what happens.

Finally, attached is a single packet capture from a test run over hwsim,
which can be used with wireshark.


Once this is adopted I'd try to get the wireshark base changes in, and
then really using it will only happen with future fields, e.g. S1G.

johannes

[-- Attachment #2: tlv-example.pcap --]
[-- Type: application/vnd.tcpdump.pcap, Size: 372 bytes --]