RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Simon Barber <simon-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Cc: aviya.erenfeld-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [RFA] timestamp field
Date: Wed, 20 Jan 2016 09:46:35 -0800
Message-ID: <569FC7FB.8090009@superduper.net> (raw)
In-Reply-To: <1453293763.13263.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>

I like this proposal. One aspect that is missing is to define the 
meaning of the timestamp with aggregates. Should this field be present 
for all subframes, or just the first/last? Should the timestamp refer to 
the subframes, or the whole A-MPDU? Currently what I see in different 
generators is the MACTIME field is either the same for all subframes, 
and always refers to the whole A-MPDU - not individual subframes. For 
one generator the MACTIME was 0 for subframes after the 1st. Sometimes 
the signal strength is only present on the last subframe.

Macbooks generate radtiotap files with incorrect rate fields for 
subframes with CRC errors.

If you look in the wireshark gerrit, you will see I have been porting my 
timeline viewer code over to the current devel mainline.

Simon

On 1/20/2016 4:42 AM, Johannes Berg wrote:
> Repost, since a few weeks have passed.
>
> Any comments?
>
> Simon, would this help you at all?
>
> johannes
>
> On Fri, 2015-12-04 at 14:41 +0100, Johannes Berg wrote:
>> Hi all,
>>
>> This is a request for adoption of the timestamp field as documented on
>> http://www.radiotap.org/suggested-fields/timestamp
>>
>> I've attached the necessary wireshark patch, as well as a patch to the
>> Linux hardware simulator (mac80211_hwsim) to generate a dummy field for
>> experimentation.
>>
>> I'd previously sent an RFC, but I didn't receive that much feedback so
>> I've just tried to be fairly generic here.
>>
>> johannes

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 13:41 Johannes Berg
     [not found] ` <1449236499.2574.4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-20 12:42   ` Johannes Berg
     [not found]     ` <1453293763.13263.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-20 17:46       ` Simon Barber [this message]
     [not found]         ` <569FC7FB.8090009-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2016-01-21  7:40           ` Johannes Berg
     [not found]             ` <1453362011.13263.13.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-02-03 22:29               ` Simon Barber
2016-06-02  9:30           ` Johannes Berg
2016-06-02  9:31   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569FC7FB.8090009@superduper.net \
    --to=simon-vp0mx6+5gkqfx2apin6yfw@public.gmane.org \
    --cc=aviya.erenfeld-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org radiotap@archiver.kernel.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git