RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Richard Sharpe
	<realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org,
	Ray Wang <rwang-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org>,
	Tasheng Lin <tlin-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org>,
	"Aaron J. Lee"
	<yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: Radiotap header for S1G captures and associated changes and other definitions
Date: Tue, 09 Apr 2019 10:58:58 +0200
Message-ID: <6141d4a8b8422b0e7e06b1457bd9a46fae37a5c2.camel@sipsolutions.net> (raw)
In-Reply-To: <CACyXjPy-Lr143wcWaLkv-xgs9Ebc0j8pYfw8MzMXNEv2tLA0Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, 2019-03-04 at 19:18 -0800, Richard Sharpe wrote:
> This is a third attempt at a RADIOTAP header for S1G captures.

What's the status of this, were you going to resend?

Not sure I mentioned it before, but I think you shouldn't use bit 16 for
S1G, see below.

I just resent my proposal for TLV fields, and I also think we should get
that in before we add the S1G field, because ... we've run out of bits
in the first presence bitmap!

We're using all the bits 0-27 (other than 15 and 16 which are awkwardly
used for different things in different OSes).

Only bit 28 is free, bit 29 is the special "new radiotap namespace", bit
30 is the special "new vendor namespace", and bit 31 of course is the
extension.

Thus I think we should use bit 28 for the TLV switch so we won't always
have to generate an extension presence bitmap when we generate a TLV
type header.

What do you think?

johannes

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05  3:18 Richard Sharpe
     [not found] ` <CACyXjPy-Lr143wcWaLkv-xgs9Ebc0j8pYfw8MzMXNEv2tLA0Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-05 11:58   ` Johannes Berg
     [not found]     ` <56728a565c1f84862615f8804881bf72b7d12511.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-03-05 15:29       ` Richard Sharpe
     [not found]         ` <CACyXjPxL1Jr7xXCh9tDBaORB5YyiJH7Zb2H+sKsz3mjUCbxkkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-06  8:07           ` yodazhong-Re5JQEeQqe8AvxtiuMwx3w
2019-04-09  8:58   ` Johannes Berg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-03-02  1:59 Richard Sharpe

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6141d4a8b8422b0e7e06b1457bd9a46fae37a5c2.camel@sipsolutions.net \
    --to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
    --cc=radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org \
    --cc=realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rwang-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org \
    --cc=tlin-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org \
    --cc=yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git