From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: Proposal for an S1G header for radiotap Date: Tue, 05 Feb 2019 10:55:27 +0100 Message-ID: <885a63e846a5c08b111601dfd25bf352c3763538.camel@sipsolutions.net> References: <8d1bb1c53c670e7cfddfc0cf2f5e2447b2ee2ecb.camel@sipsolutions.net> <01da01d4ba7a$08824ac0$1986e040$@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: radiotap-owner-sUITvd46vNxg9hUCZPvPmw@public.gmane.org List-Unsubscribe: To: Ray Wang , "yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , 'Richard Sharpe' Cc: "radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org" , Tasheng Lin List-Id: radiotap@radiotap.org Hi, > As to Aggregation related to A-MPDU, from 802.11ah -2016 spec it can > be seen the field is defined in SIG-2 of SIG field of S1G_SHORT > preamble, SIG-A2 of SIG-A field of S1G_LONG preamble, and SIG-2 of SIG > field of S1G_1M preamble. > > If looking at 802.11-2016 and Draft P802.11ax_D3.3 specs, the same > field is defined only in HT-SIG, but not in VHT-SIG-A and VHT-SIG-B, > and not in HE-SIG-A. > > From the spec perspective regarding the Aggregation field, 802.11ah is > different from 802.11n/ac/ax. Well, OK. But we still use the A-MPDU field for HT/VHT/HE, even if those are also different. We've gone for a more semantic view I guess, and you can easily distinguish which kind of frame you had by the presence of HT/VHT/HE fields and/or channel information. > As you pointed out, Richard, if the existing field can be reused it > might need some changes. If defining a new one, the existing one > probably also needs to be handled. > > What would you suggest is the best way to tackle it? Can you say what you actually want to capture for aggregation data? So far you only had an "aggregation" bit, which could be easily indicated by the presence of the A-MPDU field. But the A-MPDU reference number in radiotap, which is something that obviously doesn't even exist in the 802.11 spec, would make sense so you know which PSDUs belonged into the same aggregate. johannes