RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Krishna Chaitanya <chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Richard Sharpe
	<realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: Re: DMG Support
Date: Fri, 28 Jun 2019 01:26:12 +0530
Message-ID: <CABPxzYJyabjkEx5SwF_iED8=vBcUxFj7WtHYG=n8ssAb6u5O_g@mail.gmail.com> (raw)
In-Reply-To: <CACyXjPz5YD9VUcmbtO68nexEbjpaQOeZnLixs078c3FvW2B7eA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Thu, Jun 27, 2019 at 11:46 PM Richard Sharpe
<realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> On Thu, Jun 27, 2019 at 10:16 AM Krishna Chaitanya
> <chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > Hi Guys,
> >
> > I am looking at support for DMG specific fields to radiotap, the only
> > discussion I have found didn't reach any conclusion [1].
> >
> > Is there a plan to support these fields? It definitely needs a DMG
> > Type field with at least below params (from top of my head)
> >
> > - MCS (and extended MCS) along with data rate mapping
> >    - C-PHY
> >    - SC-PHY
> >    - Low power SC-PHY
> >    -OFDM
> > - Beam/Sector/Antenna ID Information
> > - RCPI
>
> Is there any kernel capture code or any other device that would support this?
Yes, https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/ath/wil6210/txrx.c#L317.
(Only upstream DMG driver) But, it has minimal info due to lack of DMG
specific fields.
Although, I am not sure whether it supports other PHY info than MCS and RSSI.
We could query beams, but beam info is not present in rx_desc.

> The general procedure to get there, however, is:
>
> 1. Propose the new header.
> 2. Implement code in Wireshark to handle the header and include useful
> info in the pseudo-header
> 3. Implement code that can generate sample captures with the new header.
> 4. Get someone to add such DMG support to DMG-capable devices to
> generate the new header.

Yes, that's the norm. Before proposing the fields, just wanted to
check if there is an ongoing work or
some kind of decision. So, should I go ahead and propose those fields?

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 17:15 Krishna Chaitanya
     [not found] ` <CABPxzYLh=fcGFFAMxcNY9pFN8HOczgoPcYe_+NNMiW-uuRDe5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 18:14   ` Richard Sharpe
     [not found]     ` <CACyXjPz5YD9VUcmbtO68nexEbjpaQOeZnLixs078c3FvW2B7eA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 19:56       ` Krishna Chaitanya [this message]
     [not found]         ` <CABPxzYJyabjkEx5SwF_iED8=vBcUxFj7WtHYG=n8ssAb6u5O_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 20:40           ` Richard Sharpe
     [not found]             ` <CACyXjPzNkK6Uq5kbA8O2e_4szD7T9r6DifkLCQ5ks1h1e4sAPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-28  8:02               ` Krishna Chaitanya
     [not found]                 ` <CABPxzYKAc=J6x0UcC4TpSvgfuymyWS4N8bwCnA_dnDdS1rdgAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-28  8:24                   ` Johannes Berg
     [not found]                     ` <dfef0682ee1af5e92ccc6551f888b0118fcdd2f4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-06-28  9:55                       ` Krishna Chaitanya

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPxzYJyabjkEx5SwF_iED8=vBcUxFj7WtHYG=n8ssAb6u5O_g@mail.gmail.com' \
    --to=chaitanya.mgit-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    --cc=realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git