RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Richard Sharpe <realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: Re: [RFA] HE support
Date: Tue, 20 Feb 2018 06:59:58 -0800
Message-ID: <CACyXjPxQLN3iiCjVu5X5ZQUMGBEY9FyM9dnPmEiT7XQnaUhjEQ@mail.gmail.com> (raw)
In-Reply-To: <1519131691.16723.35.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>

On Tue, Feb 20, 2018 at 5:01 AM, Johannes Berg
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> On Tue, 2018-02-20 at 10:37 +0100, Johannes Berg wrote:
>> On Tue, 2018-01-30 at 09:25 +0100, Johannes Berg wrote:
>>
>> > Rather than copy/paste all the information into the email, here are the
>> > links to the three newly defined fields.
>> > http://www.radiotap.org/fields/HE
>> > http://www.radiotap.org/fields/HE-MU
>> > http://www.radiotap.org/fields/HE-MU-other-user
>> >
>> > I just made a minor change here to delete the duplicated field, and add
>> > an RU offset field (with known flag, of course).
>>
>> Oops, I have to make another update to this - we need a
>> "primary/secondary 80 MHz bit" (along with validity).
>>
>> I think I'll put that into data2 bits 0/31, any objections?
>
> Just found another thing too.
>
> In HE-MU, I had defined:
> flags1: 0x0080: Bandwidth from SIG-A known
> flags2: 0x0007: Bandwidth from SIG-A
>
> Where this was intended to be like in the spec, which means:
>  0 - 20 MHz non-puncturing
>  1 - 40 MHz non-puncturing
>  2 - 80 MHz non-puncturing
>  3 - 160/80+80 MHz non-puncturing
>  4/5/6/7 - the various puncturing modes
>
>
> I think it'd be better to split this:
> flags1: 0x0080: reserved
> flags2: 0x0003: bandwidth from bw field in HE-SIG-A with the values
>                  0 - 20 MHz
>                  1 - 40 MHz
>                  2 - 80 MHz
>                  3 - 160/80+80 MHz
> flags2: 0x0004: bandwidth from bw field in HE-SIG-A known
> flags2: 0x0008: preamble puncturing from bw field in HE-SIG-A known
> flags2: 0x0300: preamble puncturing from bw field in HE-SIG-A,
>                 with the values
>                  0 - non-puncturing mode
>                  1 - punctured secondary 20 MHz
>                      (in primary 80 MHz if applicable)
>                      [maps to HE-SIG-A bandwidth values 4 or 6]
>                  2 - punctured but primary 40 MHz is presented
>                      (in primary 80 MHz if applicable)
>                      [maps to HE-SIG-A bandwidth values 5 or 7]
>
> Richard, did you do any work on the HE-MU field yet that would collide
> with such a change?

I have, but:

1. It's WIP, so it has not been merged yet, and
2. It looks like maybe an hour's work at most to fix it.

So, I would say, accuracy is more important.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

  parent reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  8:25 Johannes Berg
     [not found] ` <1517300719.2189.51.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20  9:37   ` Johannes Berg
     [not found]     ` <1519119420.16723.26.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20 13:01       ` Johannes Berg
     [not found]         ` <1519131691.16723.35.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20 14:59           ` Richard Sharpe [this message]
     [not found]             ` <CACyXjPxQLN3iiCjVu5X5ZQUMGBEY9FyM9dnPmEiT7XQnaUhjEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-20 15:06               ` Johannes Berg
2018-02-20 16:05       ` Richard Sharpe
2018-02-20 16:42   ` Johannes Berg
     [not found]     ` <1519144938.16723.42.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-22 11:13       ` Johannes Berg
2018-04-12  9:35   ` Johannes Berg
     [not found]     ` <1523525707.12930.6.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-04-12  9:54       ` Guy Harris
     [not found]         ` <9FE36B35-5238-436D-9B5A-342C92D20701-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2018-04-12  9:55           ` Johannes Berg
     [not found]             ` <1523526947.12930.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-04-12 13:56               ` Richard Sharpe

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACyXjPxQLN3iiCjVu5X5ZQUMGBEY9FyM9dnPmEiT7XQnaUhjEQ@mail.gmail.com \
    --to=realrichardsharpe-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git