RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Ray Wang <rwang-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	"yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	'Richard Sharpe'
	<realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org"
	<radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org>,
	Tasheng Lin <tlin-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org>
Subject: RE: Proposal for an S1G header for radiotap
Date: Tue, 5 Feb 2019 19:19:14 +0000
Message-ID: <CY1PR07MB27162E2861A1A0D4501AA54CFF6E0@CY1PR07MB2716.namprd07.prod.outlook.com> (raw)
In-Reply-To: <885a63e846a5c08b111601dfd25bf352c3763538.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>

Hi Johannes,

Thank you so much for your insight!

I agree with you that it is only an "aggregation" bit, The currently defined A-MPDU status field should be sufficient for that purpose as long as the SIG and SIG-A fields can be decoded in the corresponding S1G preambles, and A-MPDU status is populated or not populated accordingly.


Thanks,
Ray


-----Original Message-----
From: Johannes Berg [mailto:johannes@sipsolutions.net] 
Sent: Tuesday, February 05, 2019 1:55 AM
To: Ray Wang <rwang@wi-fi.org>; yodazhong@gmail.com; 'Richard Sharpe' <realrichardsharpe@gmail.com>
Cc: radiotap@radiotap.org; Tasheng Lin <tlin@wi-fi.org>
Subject: Re: Proposal for an S1G header for radiotap

Hi,

> As to Aggregation related to A-MPDU, from 802.11ah -2016 spec it can 
> be seen the field is defined in SIG-2 of SIG field of S1G_SHORT 
> preamble, SIG-A2 of SIG-A field of S1G_LONG preamble, and SIG-2 of SIG 
> field of S1G_1M preamble.
> 
> If looking at 802.11-2016 and Draft P802.11ax_D3.3 specs, the same 
> field is defined only in HT-SIG, but not in VHT-SIG-A and VHT-SIG-B, 
> and not in HE-SIG-A.
> 
> From the spec perspective regarding the Aggregation field, 802.11ah is 
> different from 802.11n/ac/ax.

Well, OK. But we still use the A-MPDU field for HT/VHT/HE, even if those are also different. We've gone for a more semantic view I guess, and you can easily distinguish which kind of frame you had by the presence of HT/VHT/HE fields and/or channel information.

> As you pointed out, Richard, if the existing field can be reused it 
> might need some changes. If defining a new one, the existing one 
> probably also needs to be handled.
> 
> What would you suggest is the best way to tackle it?

Can you say what you actually want to capture for aggregation data? So far you only had an "aggregation" bit, which could be easily indicated by the presence of the A-MPDU field. But the A-MPDU reference number in radiotap, which is something that obviously doesn't even exist in the
802.11 spec, would make sense so you know which PSDUs belonged into the same aggregate.

johannes


  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  0:02 Richard Sharpe
     [not found] ` <CACyXjPwCydx6fumWdXdLvg-StsRcALBLc5+4fCsGDaC7tcZXCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-02-01 11:33   ` Johannes Berg
     [not found]     ` <8d1bb1c53c670e7cfddfc0cf2f5e2447b2ee2ecb.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-02-01 18:35       ` Richard Sharpe
     [not found]         ` <CACyXjPzc--Deaecx9HuV5i0jyO5uUKFOqEeUaWWv3oYXqBqc8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-02-01 22:03           ` yodazhong-Re5JQEeQqe8AvxtiuMwx3w
2019-02-01 23:04             ` Ray Wang
     [not found]               ` <CY1PR07MB27160AEE154215058A2CA4F2FF920-p80jK0/XGTb2cgXex6xO0uFPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-02-05  9:55                 ` Johannes Berg
     [not found]                   ` <885a63e846a5c08b111601dfd25bf352c3763538.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-02-05 19:19                     ` Ray Wang [this message]
2019-02-05  9:17             ` Johannes Berg

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY1PR07MB27162E2861A1A0D4501AA54CFF6E0@CY1PR07MB2716.namprd07.prod.outlook.com \
    --to=rwang-+oaq/okkt+3ytjvyw6ydsg@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org \
    --cc=realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tlin-+OaQ/Okkt+3YtjvyW6yDsg@public.gmane.org \
    --cc=yodazhong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git