RCU Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h
@ 2019-08-22  1:53 Christoph Hellwig
  2019-08-22  3:02 ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-08-22  1:53 UTC (permalink / raw)
  To: paulmck, josh; +Cc: rcu, linux-kernel

The kbuild reported a built failure due to a header loop when RCUTINY is
enabled with my pending riscv-nommu port.  Switch rcutiny.h to only
include the minimal required header to get HZ instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/rcutiny.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
index 8e727f57d814..9bf1dfe7781f 100644
--- a/include/linux/rcutiny.h
+++ b/include/linux/rcutiny.h
@@ -12,7 +12,7 @@
 #ifndef __LINUX_TINY_H
 #define __LINUX_TINY_H
 
-#include <linux/ktime.h>
+#include <asm/param.h> /* for HZ */
 
 /* Never flag non-existent other CPUs! */
 static inline bool rcu_eqs_special_set(int cpu) { return false; }
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h
  2019-08-22  1:53 [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h Christoph Hellwig
@ 2019-08-22  3:02 ` Paul E. McKenney
  2019-08-22  3:48   ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2019-08-22  3:02 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: josh, rcu, linux-kernel

On Thu, Aug 22, 2019 at 10:53:43AM +0900, Christoph Hellwig wrote:
> The kbuild reported a built failure due to a header loop when RCUTINY is
> enabled with my pending riscv-nommu port.  Switch rcutiny.h to only
> include the minimal required header to get HZ instead.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Queued for review and testing, thank you!

Do you need this in v5.4?  My normal workflow would put it into v5.5.

							Thanx, Paul

> ---
>  include/linux/rcutiny.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
> index 8e727f57d814..9bf1dfe7781f 100644
> --- a/include/linux/rcutiny.h
> +++ b/include/linux/rcutiny.h
> @@ -12,7 +12,7 @@
>  #ifndef __LINUX_TINY_H
>  #define __LINUX_TINY_H
>  
> -#include <linux/ktime.h>
> +#include <asm/param.h> /* for HZ */
>  
>  /* Never flag non-existent other CPUs! */
>  static inline bool rcu_eqs_special_set(int cpu) { return false; }
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h
  2019-08-22  3:02 ` Paul E. McKenney
@ 2019-08-22  3:48   ` Christoph Hellwig
  2019-08-22 14:00     ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-08-22  3:48 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Christoph Hellwig, josh, rcu, linux-kernel

On Wed, Aug 21, 2019 at 08:02:00PM -0700, Paul E. McKenney wrote:
> On Thu, Aug 22, 2019 at 10:53:43AM +0900, Christoph Hellwig wrote:
> > The kbuild reported a built failure due to a header loop when RCUTINY is
> > enabled with my pending riscv-nommu port.  Switch rcutiny.h to only
> > include the minimal required header to get HZ instead.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Queued for review and testing, thank you!
> 
> Do you need this in v5.4?  My normal workflow would put it into v5.5.

I hope the riscv-nommu coe gets merges for 5.4, so if we could queue
it up for that I'd appreciate it.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h
  2019-08-22  3:48   ` Christoph Hellwig
@ 2019-08-22 14:00     ` Paul E. McKenney
  0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2019-08-22 14:00 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: josh, rcu, linux-kernel

On Thu, Aug 22, 2019 at 05:48:41AM +0200, Christoph Hellwig wrote:
> On Wed, Aug 21, 2019 at 08:02:00PM -0700, Paul E. McKenney wrote:
> > On Thu, Aug 22, 2019 at 10:53:43AM +0900, Christoph Hellwig wrote:
> > > The kbuild reported a built failure due to a header loop when RCUTINY is
> > > enabled with my pending riscv-nommu port.  Switch rcutiny.h to only
> > > include the minimal required header to get HZ instead.
> > > 
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > Queued for review and testing, thank you!
> > 
> > Do you need this in v5.4?  My normal workflow would put it into v5.5.
> 
> I hope the riscv-nommu coe gets merges for 5.4, so if we could queue
> it up for that I'd appreciate it.

OK, it did pass rcutorture's various !SMP scenarios, so this seems
plausible.

I am sending my main pull request today, but will also put this patch
where 0day and -next can see it.  If it does OK with that and with
additional review/testing for a few days, I will send a second pull
request with that patch some time next week.

							Thanx, Paul

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22  1:53 [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h Christoph Hellwig
2019-08-22  3:02 ` Paul E. McKenney
2019-08-22  3:48   ` Christoph Hellwig
2019-08-22 14:00     ` Paul E. McKenney

RCU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/rcu/0 rcu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 rcu rcu/ https://lore.kernel.org/rcu \
		rcu@vger.kernel.org
	public-inbox-index rcu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.rcu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git