From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A998C3A5A1 for ; Wed, 28 Aug 2019 20:28:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C2B220856 for ; Wed, 28 Aug 2019 20:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567024129; bh=8WT6MPqZUF45J3CaJnVxSCdIymyrBaY2vdML4VVCils=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=crNLPk1BPtijBg2OGioeNu0OiMQR2bO5IN2V4x2BpTfKrV1TAiIUPJvP2/W8m4FL2 3v2Xe4oGv4npDAsNT+uB6cuefHPPQeoBUS33vdNegiJxv7iMe1r+JxgrJKwk0HmYGT 2s3DA+ErF6dTJwk9ZOT/GPUYmz25Bc7Qf8vuHDWk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbfH1U2s (ORCPT ); Wed, 28 Aug 2019 16:28:48 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33372 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726687AbfH1U2s (ORCPT ); Wed, 28 Aug 2019 16:28:48 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7SKRbsa032948; Wed, 28 Aug 2019 16:28:09 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2up0etgdcu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 16:28:09 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x7SKRdaL033142; Wed, 28 Aug 2019 16:28:08 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 2up0etgdcf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 16:28:08 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7SKOoNo021576; Wed, 28 Aug 2019 20:28:07 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04dal.us.ibm.com with ESMTP id 2ujvv6xd1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2019 20:28:07 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7SKS6um41615814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Aug 2019 20:28:07 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1A9FB2065; Wed, 28 Aug 2019 20:28:06 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3756B205F; Wed, 28 Aug 2019 20:28:06 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.154]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 28 Aug 2019 20:28:06 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 8791F16C65DE; Wed, 28 Aug 2019 13:28:08 -0700 (PDT) Date: Wed, 28 Aug 2019 13:28:08 -0700 From: "Paul E. McKenney" To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, byungchul.park@lge.com, Josh Triplett , Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , rcu@vger.kernel.org, Steven Rostedt , kernel-team@android.com Subject: Re: [PATCH 0/5] kfree_rcu() additions for -rcu Message-ID: <20190828202808.GT26530@linux.ibm.com> Reply-To: paulmck@kernel.org References: <5d657e30.1c69fb81.54250.01dc@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d657e30.1c69fb81.54250.01dc@mx.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-28_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=989 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908280201 Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Tue, Aug 27, 2019 at 03:01:54PM -0400, Joel Fernandes (Google) wrote: > Hi, > > This is a series on top of the patch "rcu/tree: Add basic support for kfree_rcu() batching". > > Link: http://lore.kernel.org/r/20190814160411.58591-1-joel@joelfernandes.org > > It adds performance tests, some clean ups and removal of "lazy" RCU callbacks. > > Now that kfree_rcu() is handled separately from call_rcu(), we also get rid of > kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. > This also results in a nice negative delta as well. > > Joel Fernandes (Google) (5): > rcu/rcuperf: Add kfree_rcu() performance Tests > rcu/tree: Add multiple in-flight batches of kfree_rcu work > rcu/tree: Add support for debug_objects debugging for kfree_rcu() > rcu: Remove kfree_rcu() special casing and lazy handling > rcu: Remove kfree_call_rcu_nobatch() > > Documentation/RCU/stallwarn.txt | 13 +- > .../admin-guide/kernel-parameters.txt | 13 ++ > include/linux/rcu_segcblist.h | 2 - > include/linux/rcutiny.h | 5 - > include/linux/rcutree.h | 1 - > include/trace/events/rcu.h | 32 ++-- > kernel/rcu/rcu.h | 27 --- > kernel/rcu/rcu_segcblist.c | 25 +-- > kernel/rcu/rcu_segcblist.h | 25 +-- > kernel/rcu/rcuperf.c | 173 +++++++++++++++++- > kernel/rcu/srcutree.c | 4 +- > kernel/rcu/tiny.c | 29 ++- > kernel/rcu/tree.c | 145 ++++++++++----- > kernel/rcu/tree.h | 1 - > kernel/rcu/tree_plugin.h | 42 +---- > kernel/rcu/tree_stall.h | 6 +- > 16 files changed, 337 insertions(+), 206 deletions(-) Looks like a 131-line positive delta to me. ;-) Thanx, Paul