From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, byungchul.park@lge.com,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-doc@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
kernel-team@android.com
Subject: Re: [PATCH 0/5] kfree_rcu() additions for -rcu
Date: Wed, 28 Aug 2019 13:46:24 -0700 [thread overview]
Message-ID: <20190828204624.GV26530@linux.ibm.com> (raw)
In-Reply-To: <20190828203458.GA75931@google.com>
On Wed, Aug 28, 2019 at 04:34:58PM -0400, Joel Fernandes wrote:
> On Wed, Aug 28, 2019 at 01:28:08PM -0700, Paul E. McKenney wrote:
> > On Tue, Aug 27, 2019 at 03:01:54PM -0400, Joel Fernandes (Google) wrote:
> > > Hi,
> > >
> > > This is a series on top of the patch "rcu/tree: Add basic support for kfree_rcu() batching".
> > >
> > > Link: http://lore.kernel.org/r/20190814160411.58591-1-joel@joelfernandes.org
> > >
> > > It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
> > >
> > > Now that kfree_rcu() is handled separately from call_rcu(), we also get rid of
> > > kfree "lazy" handling from tree RCU as suggested by Paul which will be unused.
> > > This also results in a nice negative delta as well.
> > >
> > > Joel Fernandes (Google) (5):
> > > rcu/rcuperf: Add kfree_rcu() performance Tests
> > > rcu/tree: Add multiple in-flight batches of kfree_rcu work
> > > rcu/tree: Add support for debug_objects debugging for kfree_rcu()
> > > rcu: Remove kfree_rcu() special casing and lazy handling
> > > rcu: Remove kfree_call_rcu_nobatch()
> > >
> > > Documentation/RCU/stallwarn.txt | 13 +-
> > > .../admin-guide/kernel-parameters.txt | 13 ++
> > > include/linux/rcu_segcblist.h | 2 -
> > > include/linux/rcutiny.h | 5 -
> > > include/linux/rcutree.h | 1 -
> > > include/trace/events/rcu.h | 32 ++--
> > > kernel/rcu/rcu.h | 27 ---
> > > kernel/rcu/rcu_segcblist.c | 25 +--
> > > kernel/rcu/rcu_segcblist.h | 25 +--
> > > kernel/rcu/rcuperf.c | 173 +++++++++++++++++-
> > > kernel/rcu/srcutree.c | 4 +-
> > > kernel/rcu/tiny.c | 29 ++-
> > > kernel/rcu/tree.c | 145 ++++++++++-----
> > > kernel/rcu/tree.h | 1 -
> > > kernel/rcu/tree_plugin.h | 42 +----
> > > kernel/rcu/tree_stall.h | 6 +-
> > > 16 files changed, 337 insertions(+), 206 deletions(-)
> >
> > Looks like a 131-line positive delta to me. ;-)
>
> Not if you overlook the rcuperf changes which is just test code. :-D ;-)
Which suggests that you should move the "nice negative delta" comment
to the commits that actually have nice negative deltas. ;-)
Thanx, Paul
next prev parent reply other threads:[~2019-08-28 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 19:01 [PATCH 0/5] kfree_rcu() additions for -rcu Joel Fernandes (Google)
2019-08-28 20:28 ` Paul E. McKenney
2019-08-28 20:34 ` Joel Fernandes
2019-08-28 20:46 ` Paul E. McKenney [this message]
2019-08-28 21:26 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828204624.GV26530@linux.ibm.com \
--to=paulmck@kernel.org \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).