From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, byungchul.park@lge.com,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-doc@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
kernel-team@android.com
Subject: Re: [PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()
Date: Wed, 28 Aug 2019 14:57:51 -0700 [thread overview]
Message-ID: <20190828215751.GB26530@linux.ibm.com> (raw)
In-Reply-To: <20190828214320.GE75931@google.com>
On Wed, Aug 28, 2019 at 05:43:20PM -0400, Joel Fernandes wrote:
> On Wed, Aug 28, 2019 at 02:31:19PM -0700, Paul E. McKenney wrote:
> > On Tue, Aug 27, 2019 at 03:01:57PM -0400, Joel Fernandes (Google) wrote:
> > > Make use of RCU's debug_objects debugging support
> > > (CONFIG_DEBUG_OBJECTS_RCU_HEAD) similar to call_rcu() and other flavors.
> >
> > Other flavors? Ah, call_srcu(), rcu_barrier(), and srcu_barrier(),
> > right?
>
> Yes.
>
> > > We queue the object during the kfree_rcu() call and dequeue it during
> > > reclaim.
> > >
> > > Tested that enabling CONFIG_DEBUG_OBJECTS_RCU_HEAD successfully detects
> > > double kfree_rcu() calls.
> > >
> > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> >
> > The code looks good!
>
> thanks, does that mean you'll ack/apply it? :-P
Is it independent of 1/5 and 2/5?
Thanx, Paul
> - Joel
>
> >
> > Thanx, Paul
> >
> > > ---
> > > kernel/rcu/tree.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > > index 9b9ae4db1c2d..64568f12641d 100644
> > > --- a/kernel/rcu/tree.c
> > > +++ b/kernel/rcu/tree.c
> > > @@ -2757,6 +2757,7 @@ static void kfree_rcu_work(struct work_struct *work)
> > > for (; head; head = next) {
> > > next = head->next;
> > > /* Could be possible to optimize with kfree_bulk in future */
> > > + debug_rcu_head_unqueue(head);
> > > __rcu_reclaim(rcu_state.name, head);
> > > cond_resched_tasks_rcu_qs();
> > > }
> > > @@ -2868,6 +2869,13 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func)
> > > if (rcu_scheduler_active != RCU_SCHEDULER_RUNNING)
> > > return kfree_call_rcu_nobatch(head, func);
> > >
> > > + if (debug_rcu_head_queue(head)) {
> > > + /* Probable double kfree_rcu() */
> > > + WARN_ONCE(1, "kfree_call_rcu(): Double-freed call. rcu_head %p\n",
> > > + head);
> > > + return;
> > > + }
> > > +
> > > head->func = func;
> > >
> > > local_irq_save(flags); /* For safely calling this_cpu_ptr(). */
> > > --
> > > 2.23.0.187.g17f5b7556c-goog
> > >
prev parent reply other threads:[~2019-08-28 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 19:01 [PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu() Joel Fernandes (Google)
2019-08-28 21:31 ` Paul E. McKenney
2019-08-28 21:43 ` Joel Fernandes
2019-08-28 21:57 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828215751.GB26530@linux.ibm.com \
--to=paulmck@kernel.org \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).