From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC59CC3A59F for ; Thu, 29 Aug 2019 13:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A44F3215EA for ; Thu, 29 Aug 2019 13:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="B7vedP+3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbfH2N7K (ORCPT ); Thu, 29 Aug 2019 09:59:10 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40862 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbfH2N7K (ORCPT ); Thu, 29 Aug 2019 09:59:10 -0400 Received: by mail-pl1-f195.google.com with SMTP id h3so1614381pls.7 for ; Thu, 29 Aug 2019 06:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=40EqMQd0G4SVbrZfGPeA5SE4upLhPO04pKe2ongbivs=; b=B7vedP+381Vda1eCJ1DpCKGye34MvOP4SaLRfcWFXrezjckDaL2DCJkysvbc5x6x9K 5ZHaAq8dolDDtXD5Emsjg2p4yLOStQjh6ER9RX2SxOPJPrpxQ9KcL7NtxmBaNUHUfkqr 9SWPCrsL1tOOGwTXDBiFQSW/yOhdLnH2Y9d3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=40EqMQd0G4SVbrZfGPeA5SE4upLhPO04pKe2ongbivs=; b=f5ZpBmMEVADA58KchKqG82ISBQY/nMjzyiM2s8EZkyKJkxlZuR/PUH9qeEQj5gN3wV jH3qx1vpV1f4Nel+6YEUrajw5dFfn7bWyYxoBgp1YPGz+f7jyHc0xe88WVTWbdD8TON9 FP0/wKLODViRFQ6MQ/rsxmal4BcsTOLGy68/HtJTqdtB+6/GP/CJusa7Vl+0mXQplCgj Y24hca65apSnktsTXQFkImCx3UfI0pdstRAojpKLM5kMl3HtKxLVtnexNf+Y8MZy4VvG gZeY01VJmtpYO9piBFYadN6/r+1Q4Js2tp6Aso49JaU+LsVwsVot4aF68C3Z5f14+vz6 t0UQ== X-Gm-Message-State: APjAAAUuioDf76LbYhkoFqIk3iG7M7hY/Yn1sIbM0pxcqOdKIMbf2hVc Wg+gMmUEUwo9O49oAV4lrQZajA== X-Google-Smtp-Source: APXvYqyN3H4PkVt4D8iZLYVpLv8rCMjL0d2y1VW3RXuJ+ApI39d4sYSpewllOECHNz60vokFKp1bBQ== X-Received: by 2002:a17:902:223:: with SMTP id 32mr10245894plc.220.1567087149497; Thu, 29 Aug 2019 06:59:09 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id dw7sm2200431pjb.21.2019.08.29.06.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 06:59:08 -0700 (PDT) Date: Thu, 29 Aug 2019 09:59:07 -0400 From: Joel Fernandes To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker , Jonathan Corbet , Josh Triplett , kernel-team@android.com, Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , Mauro Carvalho Chehab , rcu@vger.kernel.org, Steven Rostedt Subject: Re: [RFC v1 2/2] rcu/tree: Remove dynticks_nmi_nesting counter Message-ID: <20190829135907.GC63638@google.com> References: <5d648897.1c69fb81.5e60a.fc70@mx.google.com> <20190828202330.GS26530@linux.ibm.com> <20190828210525.GB75931@google.com> <20190828211904.GX26530@linux.ibm.com> <20190828214241.GD75931@google.com> <20190828220108.GC26530@linux.ibm.com> <20190828221444.GA100789@google.com> <20190828231247.GE26530@linux.ibm.com> <20190829015155.GB100789@google.com> <20190829034336.GD4125@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829034336.GD4125@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Wed, Aug 28, 2019 at 08:43:36PM -0700, Paul E. McKenney wrote: [snip] > On the tracing patch... That patch might be a good idea regardless, > but I bet that the reason that you felt the sudden need for it was due > to the loss of information in your eventual ->dynticks_nesting field. > After all, the value 0x1 might be an interrupt from idle, or it might > just as easily be a task running in the kernel at process level. True, however what really triggered me to do it was the existing code which does not distinguish between entry/exit from USER and IDLE. > The reason the patch might nevertheless be a good idea is that redundant > information can be helpful when debugging. Especially when debugging > new architecture-specific code, which is when RCU's dyntick-idle warnings > tend to find bugs. Sure, and also that it is more readable to ordinary human beings than "++=" and "--=" :-D. thanks, - Joel