From: "Paul E. McKenney" <paulmck@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: rcu@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
dipankar@in.ibm.com, Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Josh Triplett <josh@joshtriplett.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
David Howells <dhowells@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH tip/core/rcu 9/9] rcu: Suppress levelspread uninitialized messages
Date: Sat, 5 Oct 2019 09:16:08 -0700 [thread overview]
Message-ID: <20191005161608.GH2689@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <CAMuHMdW5+RSp6iycmyPnYPv+xHr5tNY7U3w-BVrWqz4BR2Dd7w@mail.gmail.com>
On Thu, Oct 03, 2019 at 10:53:03AM +0200, Geert Uytterhoeven wrote:
> Hi Paul,
>
> On Thu, Oct 3, 2019 at 3:49 AM <paulmck@kernel.org> wrote:
> > From: "Paul E. McKenney" <paulmck@kernel.org>
> >
> > New tools bring new warnings, and with v5.3 comes:
>
> According to the kisskb build logs, it happens with gcc 4.6.3 only ;-)
>
> > kernel/rcu/srcutree.c: warning: 'levelspread[<U aa0>]' may be used uninitialized in this function [-Wuninitialized]: => 121:34
> >
> > This commit suppresses this warning by initializing the full array
> > to INT_MIN, which will result in failures should any out-of-bounds
> > references appear.
> >
> > Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> (for the initialization loop, not for the actual INT_MIN value)
Applied, thank you!
> Unfortunately I don't have a gcc-4.6.3 Linux cross-compiler anymore.
> I tried with msp430-gcc-4.6.3 and some hackery to get it to compile,
> but that didn't let me reproduce the warning.
OK, please let me know when gcc-4.6.3 is old enough that this patch
should be reverted. Or just submit the revert at that point, as the
case may be. ;-)
Thanx, Paul
prev parent reply other threads:[~2019-10-05 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 1:47 [PATCH tip/core/rcu 0/9] Torture-test updates Paul E. McKenney
2019-10-03 1:47 ` [PATCH tip/core/rcu 1/9] rcu: Remove unused function rcutorture_record_progress() paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 2/9] locktorture: Replace strncmp() with str_has_prefix() paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 3/9] rcutorture: Remove CONFIG_HOTPLUG_CPU=n from scenarios paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 4/9] rcutorture: Emulate dyntick aspect of userspace nohz_full sojourn paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 5/9] rcu: Remove unused variable rcu_perf_writer_state paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 6/9] rcutorture: Separate warnings for each failure type paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 7/9] rcutorture: Make in-kernel-loop testing more brutal paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 8/9] locking: locktorture: Do not include rwlock.h directly paulmck
2019-10-03 1:47 ` [PATCH tip/core/rcu 9/9] rcu: Suppress levelspread uninitialized messages paulmck
2019-10-03 8:53 ` Geert Uytterhoeven
2019-10-05 16:16 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005161608.GH2689@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).