RCU Archive on lore.kernel.org
 help / color / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Amol Grover <frextrite@gmail.com>,
	Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
	linux-audit@redhat.com, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	paulmck@kernel.org, rcu@vger.kernel.org, rostedt@kernel.org
Subject: Re: [PATCH v3] kernel: audit.c: Add __rcu annotation to RCU pointer
Date: Mon, 2 Dec 2019 18:34:31 -0500
Message-ID: <20191202233431.GM17234@google.com> (raw)
In-Reply-To: <20191202172639.1c9ad544@gandalf.local.home>

On Mon, Dec 02, 2019 at 05:26:39PM -0500, Steven Rostedt wrote:
> On Mon, 2 Dec 2019 16:19:15 -0500
> Joel Fernandes <joel@joelfernandes.org> wrote:
> 
> > Good idea to CC the following on RCU patches:
> > Paul McKenney
> > Steven Rostedt
> 
> I'm fine with this if it doesn't cause any rcu splats with sparse. Not
> sure if use cases of RCU requires RCU maintainers Cc'd. Although we can
> usually keep people from misusing it ;-)

Yes true :) Thanks for taking a look.

 - Joel

> 
> -- Steve
> 
> 
> > (Any others on the RCU maintainers list).
> > And, the list: rcu@vger.kernel.org
> > 
> > Could anyone Ack the patch? Looks safe and straight forward.
> > 
> > On Mon, Dec 02, 2019 at 12:03:48AM +0530, Amol Grover wrote:
> > > Add __rcu annotation to RCU-protected global pointer auditd_conn.
> > > 
> > > auditd_conn is an RCU-protected global pointer,i.e., accessed
> > > via RCU methods rcu_dereference() and rcu_assign_pointer(),
> > > hence it must be annotated with __rcu for sparse to report
> > > warnings/errors correctly.
> > > 
> > > Fix multiple instances of the sparse error:
> > > error: incompatible types in comparison expression
> > > (different address spaces)
> > > 
> > > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > > Signed-off-by: Amol Grover <frextrite@gmail.com>
> > > ---
> > > v3:
> > > - update changelog to be more descriptive
> > > 
> > > v2:
> > > - fix erroneous RCU pointer initialization
> > >  
> > >  kernel/audit.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/kernel/audit.c b/kernel/audit.c
> > > index da8dc0db5bd3..ff7cfc61f53d 100644
> > > --- a/kernel/audit.c
> > > +++ b/kernel/audit.c
> > > @@ -102,12 +102,13 @@ struct audit_net {
> > >   * This struct is RCU protected; you must either hold the RCU lock for reading
> > >   * or the associated spinlock for writing.
> > >   */
> > > -static struct auditd_connection {
> > > +struct auditd_connection {
> > >  	struct pid *pid;
> > >  	u32 portid;
> > >  	struct net *net;
> > >  	struct rcu_head rcu;
> > > -} *auditd_conn = NULL;
> > > +};
> > > +static struct auditd_connection __rcu *auditd_conn;
> > >  static DEFINE_SPINLOCK(auditd_conn_lock);
> > >  
> > >  /* If audit_rate_limit is non-zero, limit the rate of sending audit records
> > > -- 
> > > 2.24.0
> > >   
> 

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191201183347.18122-1-frextrite@gmail.com>
2019-12-02 21:19 ` Joel Fernandes
2019-12-02 22:26   ` Steven Rostedt
2019-12-02 23:34     ` Joel Fernandes [this message]
2019-12-02 23:24   ` Paul Moore
2019-12-02 23:34     ` Joel Fernandes
2019-12-09 20:31       ` Paul Moore

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202233431.GM17234@google.com \
    --to=joel@joelfernandes.org \
    --cc=eparis@redhat.com \
    --cc=frextrite@gmail.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rostedt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RCU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/rcu/0 rcu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 rcu rcu/ https://lore.kernel.org/rcu \
		rcu@vger.kernel.org
	public-inbox-index rcu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.rcu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git