From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Matthew Wilcox <willy@infradead.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Subject: Re: [PATCH 1/1] rcu/tree: Drop the lock before entering to page allocator
Date: Thu, 16 Jul 2020 16:25:37 +0200 [thread overview]
Message-ID: <20200716142537.ecp4icsq7kg6qhdx@linutronix.de> (raw)
In-Reply-To: <20200716091913.GA28595@pc636>
On 2020-07-16 11:19:13 [+0200], Uladzislau Rezki wrote:
> Sebastian, could you please confirm that if that patch that is in
> question fixes it?
>
> It would be appreciated!
So that preempt disable should in terms any warnings. However I don't
think that it is strictly needed and from scheduling point of view you
forbid a CPU migration which might be good otherwise.
Also if interrupts and everything is enabled then someone else might
invoke kfree_rcu() from BH context for instance.
Sebastian
next prev parent reply other threads:[~2020-07-16 14:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 18:35 [PATCH 1/1] rcu/tree: Drop the lock before entering to page allocator Uladzislau Rezki (Sony)
2020-07-15 18:56 ` Sebastian Andrzej Siewior
2020-07-15 19:02 ` Uladzislau Rezki
2020-07-15 19:32 ` Sebastian Andrzej Siewior
2020-07-15 19:36 ` Uladzislau Rezki
2020-07-15 22:14 ` Paul E. McKenney
2020-07-16 14:14 ` Sebastian Andrzej Siewior
2020-07-16 15:20 ` Paul E. McKenney
2020-07-16 15:36 ` Sebastian Andrzej Siewior
2020-07-16 16:36 ` Paul E. McKenney
2020-07-15 23:13 ` Joel Fernandes
2020-07-16 9:19 ` Uladzislau Rezki
2020-07-16 13:36 ` Joel Fernandes
2020-07-16 14:37 ` Uladzislau Rezki
2020-07-16 18:27 ` Joel Fernandes
2020-07-16 19:03 ` Uladzislau Rezki
2020-07-16 14:25 ` Sebastian Andrzej Siewior [this message]
2020-07-16 14:47 ` Uladzislau Rezki
2020-07-16 15:04 ` Sebastian Andrzej Siewior
2020-07-16 15:34 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716142537.ecp4icsq7kg6qhdx@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).