RCU Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rcu: remove surplus instrumentation_end in rcu_nmi_enter
@ 2021-01-11  1:08 Zhouyi Zhou
  2021-01-12 17:50 ` Paul E. McKenney
  0 siblings, 1 reply; 3+ messages in thread
From: Zhouyi Zhou @ 2021-01-11  1:08 UTC (permalink / raw)
  To: 340442286, paulmck, josh, rostedt, mathieu.desnoyers,
	jiangshanlai, joel, rcu, linux-kernel
  Cc: Zhouyi Zhou

In function rcu_nmi_enter, there is a surplus instrumentation_end
in second branch of if statement, although objtool check -f vmlinux.o will
not complain because of its inability to correctly cover all cases
(objtool will visit the third branch first, which markes
 following trace_rcu_dyntick as visited), I think remove the surplus
instrumentation_end will make the code better.


Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
 kernel/rcu/tree.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 40e5e3dd253e..eaec6f6032c2 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1021,7 +1021,6 @@ noinstr void rcu_nmi_enter(void)
 	} else if (!in_nmi()) {
 		instrumentation_begin();
 		rcu_irq_enter_check_tick();
-		instrumentation_end();
 	} else  {
 		instrumentation_begin();
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11  1:08 [PATCH] rcu: remove surplus instrumentation_end in rcu_nmi_enter Zhouyi Zhou
2021-01-12 17:50 ` Paul E. McKenney
2021-01-13  3:46   ` Zhouyi Zhou

RCU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/rcu/0 rcu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 rcu rcu/ https://lore.kernel.org/rcu \
		rcu@vger.kernel.org
	public-inbox-index rcu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.rcu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git