From: "Paul E. McKenney" <paulmck@kernel.org>
To: Stephen Zhang <stephenzhangzsd@gmail.com>
Cc: dave@stgolabs.net, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcutorture: replace the function name with %s
Date: Sat, 23 Jan 2021 08:11:01 -0800 [thread overview]
Message-ID: <20210123161101.GP2743@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <1611395657-6645-1-git-send-email-stephenzhangzsd@gmail.com>
On Sat, Jan 23, 2021 at 05:54:17PM +0800, Stephen Zhang wrote:
> Better to replace the function name with %s in case of changes.
>
> Signed-off-by: Stephen Zhang <stephenzhangzsd@gmail.com>
I queued both for the v5.13 merge window with the usual wordsmithing,
thank you!
Thanx, Paul
> ---
> kernel/rcu/rcutorture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 2440f89..e561641 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -2016,8 +2016,8 @@ static int rcu_torture_stall(void *args)
> local_irq_disable();
> else if (!stall_cpu_block)
> preempt_disable();
> - pr_alert("rcu_torture_stall start on CPU %d.\n",
> - raw_smp_processor_id());
> + pr_alert("%s start on CPU %d.\n",
> + __func__, raw_smp_processor_id());
> while (ULONG_CMP_LT((unsigned long)ktime_get_seconds(),
> stop_at))
> if (stall_cpu_block)
> @@ -2028,7 +2028,7 @@ static int rcu_torture_stall(void *args)
> preempt_enable();
> cur_ops->readunlock(idx);
> }
> - pr_alert("rcu_torture_stall end.\n");
> + pr_alert("%s end.\n", __func__);
> torture_shutdown_absorb("rcu_torture_stall");
> while (!kthread_should_stop())
> schedule_timeout_interruptible(10 * HZ);
> --
> 1.8.3.1
>
prev parent reply other threads:[~2021-01-23 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 9:54 [PATCH] rcutorture: replace the function name with %s Stephen Zhang
2021-01-23 16:11 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123161101.GP2743@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=dave@stgolabs.net \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stephenzhangzsd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).