From: "Paul E. McKenney" <paulmck@kernel.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Axtens <dja@axtens.net>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraju@codeaurora.org>,
Joel Fernandes <joel@joelfernandes.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Subject: Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument
Date: Wed, 3 Feb 2021 11:37:37 -0800 [thread overview]
Message-ID: <20210203193737.GK2743@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <YBfqa/LzVAG4+zZt@dhcp22.suse.cz>
On Mon, Feb 01, 2021 at 12:47:55PM +0100, Michal Hocko wrote:
> On Fri 29-01-21 17:35:31, Uladzislau Rezki wrote:
> > On Fri, Jan 29, 2021 at 09:56:29AM +0100, Michal Hocko wrote:
> > > On Thu 28-01-21 19:02:37, Uladzislau Rezki wrote:
> > > [...]
> > > > >From 0bdb8ca1ae62088790e0a452c4acec3821e06989 Mon Sep 17 00:00:00 2001
> > > > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
> > > > Date: Wed, 20 Jan 2021 17:21:46 +0100
> > > > Subject: [PATCH v2 1/1] kvfree_rcu: Directly allocate page for single-argument
> > > > case
> > > >
> > > > Single-argument kvfree_rcu() must be invoked from sleepable contexts,
> > > > so we can directly allocate pages. Furthermmore, the fallback in case
> > > > of page-allocation failure is the high-latency synchronize_rcu(), so it
> > > > makes sense to do these page allocations from the fastpath, and even to
> > > > permit limited sleeping within the allocator.
> > > >
> > > > This commit therefore allocates if needed on the fastpath using
> > > > GFP_KERNEL|__GFP_NORETRY.
> > >
> > > Yes, __GFP_NORETRY as a lightweight allocation mode should be fine. It
> > > is more robust than __GFP_NOWAIT on memory usage spikes. The caller is
> > > prepared to handle the failure which is likely much less disruptive than
> > > OOM or potentially heavy reclaim __GFP_RETRY_MAYFAIL.
> > >
> > > I cannot give you ack as I am not familiar with the code but this makes
> > > sense to me.
> > >
> > No problem, i can separate it. We can have a patch on top of what we have so
> > far. The patch only modifies the gfp_mask passed to __get_free_pages():
> >
> > >From ec2feaa9b7f55f73b3b17e9ac372151c1aab5ae0 Mon Sep 17 00:00:00 2001
> > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
> > Date: Fri, 29 Jan 2021 17:16:03 +0100
> > Subject: [PATCH 1/1] kvfree_rcu: replace __GFP_RETRY_MAYFAIL by __GFP_NORETRY
> >
> > __GFP_RETRY_MAYFAIL is a bit heavy from reclaim process of view,
> > therefore a time consuming. That is not optional and there is
> > no need in doing it so hard, because we have a fallback path.
> >
> > __GFP_NORETRY in its turn can perform some light-weight reclaim
> > and it rather fails under high memory pressure or low memory
> > condition.
> >
> > In general there are four simple criterias we we would like to
> > achieve:
> > a) minimize a fallback hitting;
> > b) avoid of OOM invoking;
> > c) do a light-wait page request;
> > d) avoid of dipping into the emergency reserves.
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
>
> Looks good to me. Feel free to add
> Acked-by: Michal Hocko <mhocko@suse.com>
Queued, thank you both!
Thanx, Paul
> > ---
> > kernel/rcu/tree.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index 70ddc339e0b7..1e862120db9e 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3489,8 +3489,20 @@ add_ptr_to_bulk_krc_lock(struct kfree_rcu_cpu **krcp,
> > bnode = get_cached_bnode(*krcp);
> > if (!bnode && can_alloc) {
> > krc_this_cpu_unlock(*krcp, *flags);
> > +
> > + // __GFP_NORETRY - allows a light-weight direct reclaim
> > + // what is OK from minimizing of fallback hitting point of
> > + // view. Apart of that it forbids any OOM invoking what is
> > + // also beneficial since we are about to release memory soon.
> > + //
> > + // __GFP_NOMEMALLOC - prevents from consuming of all the
> > + // memory reserves. Please note we have a fallback path.
> > + //
> > + // __GFP_NOWARN - it is supposed that an allocation can
> > + // be failed under low memory or high memory pressure
> > + // scenarios.
> > bnode = (struct kvfree_rcu_bulk_data *)
> > - __get_free_page(GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOMEMALLOC | __GFP_NOWARN);
> > + __get_free_page(GFP_KERNEL | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN);
> > *krcp = krc_this_cpu_lock(flags);
> > }
> >
> > --
> > 2.20.1
> >
> > --
> > Vlad Rezki
>
> --
> Michal Hocko
> SUSE Labs
prev parent reply other threads:[~2021-02-03 19:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:21 [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument Uladzislau Rezki (Sony)
2021-01-20 16:21 ` [PATCH 2/3] kvfree_rcu: Use __GFP_NOMEMALLOC for single-argument kvfree_rcu() Uladzislau Rezki (Sony)
2021-01-28 18:06 ` Uladzislau Rezki
2021-01-20 16:21 ` [PATCH 3/3] kvfree_rcu: use migrate_disable/enable() Uladzislau Rezki (Sony)
2021-01-20 19:45 ` Sebastian Andrzej Siewior
2021-01-20 21:42 ` Paul E. McKenney
2021-01-23 9:31 ` 回复: " Zhang, Qiang
2021-01-24 21:57 ` Uladzislau Rezki
2021-01-25 1:50 ` 回复: " Zhang, Qiang
2021-01-25 2:18 ` Zhang, Qiang
2021-01-25 13:49 ` Uladzislau Rezki
2021-01-26 9:33 ` 回复: " Zhang, Qiang
2021-01-26 13:43 ` Uladzislau Rezki
2021-01-20 18:40 ` [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument Paul E. McKenney
2021-01-20 19:57 ` Sebastian Andrzej Siewior
2021-01-20 21:54 ` Paul E. McKenney
2021-01-21 13:35 ` Uladzislau Rezki
2021-01-21 15:07 ` Paul E. McKenney
2021-01-21 19:17 ` Uladzislau Rezki
2021-01-22 11:17 ` Sebastian Andrzej Siewior
2021-01-22 15:28 ` Paul E. McKenney
2021-01-21 12:38 ` Uladzislau Rezki
2021-01-22 11:34 ` Sebastian Andrzej Siewior
2021-01-22 14:21 ` Uladzislau Rezki
2021-01-25 13:22 ` Michal Hocko
2021-01-25 14:31 ` Uladzislau Rezki
2021-01-25 15:39 ` Michal Hocko
2021-01-25 16:25 ` Uladzislau Rezki
2021-01-28 15:11 ` Uladzislau Rezki
2021-01-28 15:17 ` Michal Hocko
2021-01-28 15:30 ` Uladzislau Rezki
2021-01-28 18:02 ` Uladzislau Rezki
[not found] ` <YBPNvbJLg56XU8co@dhcp22.suse.cz>
2021-01-29 16:35 ` Uladzislau Rezki
2021-02-01 11:47 ` Michal Hocko
2021-02-01 14:44 ` Uladzislau Rezki
2021-02-03 19:37 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203193737.GK2743@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=dja@axtens.net \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=neeraju@codeaurora.org \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).