From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0745C433F5 for ; Wed, 15 Sep 2021 23:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B3FC61186 for ; Wed, 15 Sep 2021 23:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232940AbhIOXfE (ORCPT ); Wed, 15 Sep 2021 19:35:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:60304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231233AbhIOXfE (ORCPT ); Wed, 15 Sep 2021 19:35:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F33316113E; Wed, 15 Sep 2021 23:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631748825; bh=k7yNQkcydFuuP5qSmMadxFfLeKBvp9arjKxIIdfS/uI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JLsxPmqMtnp0WLRryaq9XpJB9fzVxSwockzBxaOGb/imfnXPYkfLpdM6m07DzlTmf 1OKU3kVZ5W9JzmoX/TRmHf1UCFMUPvLybZoBClkvvysT73c14eLggPU+sqyVhUeO64 +JVWavr32uQLgIxOSC8fkTsXu6MQrmeislGtdKNd0oMRr+5OrRc5+KFLY/aSw3qqYl XVMEqPWWNp9/aHBkpPoOH3le7z5Bb7dVVgxnhag2z/iTB5RMcEm9cq2h1Gqdr61CDQ UuD5QAR94mdzymV1PNB5pTdVJ9jvUhdfTQLLfx2KPa38x+CBDAoL89b7TbW78HMZwE j8J+TNHiizj9Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id BD5AB5C06B9; Wed, 15 Sep 2021 16:33:44 -0700 (PDT) From: "Paul E. McKenney" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH rcu 02/14] rcu-nocb: Fix a couple of tree_nocb code-style nits Date: Wed, 15 Sep 2021 16:33:31 -0700 Message-Id: <20210915233343.3906738-2-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20210915233305.GA3906641@paulmck-ThinkPad-P17-Gen-1> References: <20210915233305.GA3906641@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org This commit removes a non-value-returning "return" statement at the end of __call_rcu_nocb_wake() and adds a blank line following declarations in nocb_cb_can_run(). Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_nocb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 8fdf44f8523f..368ef7b9af4f 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -549,7 +549,6 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone, rcu_nocb_unlock_irqrestore(rdp, flags); trace_rcu_nocb_wake(rcu_state.name, rdp->cpu, TPS("WakeNot")); } - return; } /* @@ -767,6 +766,7 @@ static int rcu_nocb_gp_kthread(void *arg) static inline bool nocb_cb_can_run(struct rcu_data *rdp) { u8 flags = SEGCBLIST_OFFLOADED | SEGCBLIST_KTHREAD_CB; + return rcu_segcblist_test_flags(&rdp->cblist, flags); } -- 2.31.1.189.g2e36527f23